Skip to content

Commit 67ae871

Browse files
[management] return empty array instead of null on networks endpoints (#3480)
1 parent 39ff5e8 commit 67ae871

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

management/server/http/handlers/networks/handler.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ func (h *handler) collectIDsInNetwork(ctx context.Context, accountID, userID, ne
289289
}
290290

291291
func (h *handler) generateNetworkResponse(networks []*types.Network, routers map[string][]*routerTypes.NetworkRouter, resourceIDs map[string][]string, groups map[string]*nbtypes.Group, account *nbtypes.Account) []*api.Network {
292-
var networkResponse []*api.Network
292+
networkResponse := make([]*api.Network, 0, len(networks))
293293
for _, network := range networks {
294294
routerIDs, peerCounter := getRouterIDs(network, routers, groups)
295295
policyIDs := account.GetPoliciesAppliedInNetwork(network.ID)

management/server/http/handlers/networks/resources_handler.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ func (h *resourceHandler) getAllResourcesInAccount(w http.ResponseWriter, r *htt
8989

9090
grpsInfoMap := groups.ToGroupsInfoMap(grps, 0)
9191

92-
var resourcesResponse []*api.NetworkResource
92+
resourcesResponse := make([]*api.NetworkResource, 0, len(resources))
9393
for _, resource := range resources {
9494
resourcesResponse = append(resourcesResponse, resource.ToAPIResponse(grpsInfoMap[resource.ID]))
9595
}

management/server/http/handlers/networks/routers_handler.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ func (h *routersHandler) getAllRouters(w http.ResponseWriter, r *http.Request) {
4848
return
4949
}
5050

51-
var routersResponse []*api.NetworkRouter
51+
routersResponse := make([]*api.NetworkRouter, 0, len(routers))
5252
for _, router := range routers {
5353
routersResponse = append(routersResponse, router.ToAPIResponse())
5454
}

0 commit comments

Comments
 (0)