Fixes #20776: Address review feedback on bulk rename changelog

- Add explanatory comment on base_fields.pop() safety
- Add skipTest guard for models without ChangeLoggingMixin

Author: jnovinger

netbox/netbox/views/generic/bulk_views.py

@@ -891,7 +891,8 @@ class _Form(BulkRenameForm):
 
         self.form = _Form
 
-        # Remove changelog_message field if model doesn't support change logging
+        # Remove changelog_message field if model doesn't support change logging.
+        # Mutating base_fields is safe here because _Form is created fresh per request above.
         if not issubclass(self.queryset.model, ChangeLoggingMixin):
             self.form.base_fields.pop('changelog_message', None)
 

netbox/utilities/testing/views.py

@@ -1051,6 +1051,8 @@ def test_bulk_rename_objects_with_permission(self):
 
         @override_settings(EXEMPT_VIEW_PERMISSIONS=['*'])
         def test_bulk_rename_objects_with_changelog_message(self):
+            if not issubclass(self.model, ChangeLoggingMixin):
+                self.skipTest("Model does not support change logging")
             objects = self._get_queryset().all()[:3]
             pk_list = [obj.pk for obj in objects]
             data = {