Skip to content
This repository has been archived by the owner on May 4, 2019. It is now read-only.

Make it possible to exclude metrics & tracing when generating stubs #10

Open
bsideup opened this issue Jul 29, 2018 · 2 comments
Open

Comments

@bsideup
Copy link

bsideup commented Jul 29, 2018

Hi!

Currently, the generated code contains code for the metrics & tracing, even if it's optional.
Would be great to have an option to disable them at the code generation phase.

Thanks!

@bsideup bsideup changed the title Make it possible to disable metrics & tracing when generating stubs Make it possible to exclude metrics & tracing when generating stubs Jul 29, 2018
@bsideup
Copy link
Author

bsideup commented Aug 4, 2018

Hi @robertroeser!

Anything I can help with?

Currently, we can't even use compileOnly and have to put OpenTracing & MicroMeter on the classpath because of Optional<> parameters in the constructor (JVM will fail if classes are missing)

@robertroeser
Copy link
Contributor

Hi @bsideup

If you want to take a crack making OpenTracing and Micrometer options in protoc that would be cool.
Changes would have to be made here to the protoc plugin
https://github.com/netifi-proteus/proteus-java/tree/develop/protobuf-rpc/src/java_plugin/cpp

and then figure out how to send parameters to protoc to disable open tracing and micrometer

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants