PHPStan: fixed some issues

Author: JanTvrdik

src/Utils/ArrayList.php

@@ -54,7 +54,7 @@ public function offsetSet($index, $value): void
 			throw new Nette\OutOfRangeException('Offset invalid or out of range');
 
 		} else {
-			$this->list[(int) $index] = $value;
+			$this->list[$index] = $value;
 		}
 	}
 
@@ -70,7 +70,7 @@ public function offsetGet($index)
 		if (!is_int($index) || $index < 0 || $index >= count($this->list)) {
 			throw new Nette\OutOfRangeException('Offset invalid or out of range');
 		}
-		return $this->list[(int) $index];
+		return $this->list[$index];
 	}
 
 
@@ -94,7 +94,7 @@ public function offsetUnset($index): void
 		if (!is_int($index) || $index < 0 || $index >= count($this->list)) {
 			throw new Nette\OutOfRangeException('Offset invalid or out of range');
 		}
-		array_splice($this->list, (int) $index, 1);
+		array_splice($this->list, $index, 1);
 	}
 
 

src/Utils/DateTime.php

@@ -52,7 +52,7 @@ public static function from($time)
 			if ($time <= self::YEAR) {
 				$time += time();
 			}
-			return (new static('@' . $time))->setTimeZone(new \DateTimeZone(date_default_timezone_get()));
+			return (new static('@' . $time))->setTimezone(new \DateTimeZone(date_default_timezone_get()));
 
 		} else { // textual or null
 			return new static($time);
@@ -98,7 +98,7 @@ public function setTimestamp($timestamp)
 	{
 		$zone = $this->getTimezone();
 		$this->__construct('@' . $timestamp);
-		return $this->setTimeZone($zone);
+		return $this->setTimezone($zone);
 	}
 
 

src/Utils/Html.php

@@ -82,7 +82,6 @@ public static function el(string $name = null, $attrs = null)
 	/**
 	 * Changes element's name.
 	 * @return static
-	 * @throws Nette\InvalidArgumentException
 	 */
 	final public function setName(string $name, bool $isEmpty = null)
 	{
@@ -293,13 +292,9 @@ public function data(string $name, $value = null)
 	 * Sets element's HTML content.
 	 * @param  IHtmlString|string
 	 * @return static
-	 * @throws Nette\InvalidArgumentException
 	 */
 	final public function setHtml($html)
 	{
-		if (is_array($html)) {
-			throw new Nette\InvalidArgumentException(sprintf('Textual content must be a scalar, %s given.', gettype($html)));
-		}
 		$this->children = [(string) $html];
 		return $this;
 	}
@@ -318,7 +313,6 @@ final public function getHtml(): string
 	 * Sets element's textual content.
 	 * @param  IHtmlString|string
 	 * @return static
-	 * @throws Nette\InvalidArgumentException
 	 */
 	final public function setText($text)
 	{
@@ -352,7 +346,7 @@ final public function addHtml($child)
 
 	/**
 	 * Appends plain-text string to element content.
-	 * @param  IHtmlString|string
+	 * @param  IHtmlString|string|int|float
 	 * @return static
 	 */
 	public function addText($text)
@@ -380,21 +374,15 @@ final public function create(string $name, $attrs = null)
 	 * Inserts child node.
 	 * @param  IHtmlString|string $child Html node or raw HTML string
 	 * @return static
-	 * @throws Nette\InvalidArgumentException
 	 */
 	public function insert(int $index = null, $child, bool $replace = false)
 	{
-		if ($child instanceof IHtmlString || is_scalar($child)) {
-			$child = $child instanceof self ? $child : (string) $child;
-			if ($index === null) { // append
-				$this->children[] = $child;
+		$child = $child instanceof self ? $child : (string) $child;
+		if ($index === null) { // append
+			$this->children[] = $child;
 
-			} else { // insert or replace
-				array_splice($this->children, $index, $replace ? 1 : 0, [$child]);
-			}
-
-		} else {
-			throw new Nette\InvalidArgumentException(sprintf('Child node must be scalar or Html object, %s given.', is_object($child) ? get_class($child) : gettype($child)));
+		} else { // insert or replace
+			array_splice($this->children, $index, $replace ? 1 : 0, [$child]);
 		}
 
 		return $this;
@@ -440,7 +428,7 @@ final public function offsetExists($index): bool
 	public function offsetUnset($index): void
 	{
 		if (isset($this->children[$index])) {
-			array_splice($this->children, (int) $index, 1);
+			array_splice($this->children, $index, 1);
 		}
 	}
 
@@ -494,7 +482,7 @@ final public function render(int $indent = null): string
 				$indent++;
 			}
 			foreach ($this->children as $child) {
-				if (is_object($child)) {
+				if ($child instanceof self) {
 					$s .= $child->render($indent);
 				} else {
 					$s .= $child;

src/Utils/Image.php

@@ -275,7 +275,7 @@ public function resize($width, $height, int $flags = self::FIT)
 		[$newWidth, $newHeight] = static::calculateSize($this->getWidth(), $this->getHeight(), $width, $height, $flags);
 
 		if ($newWidth !== $this->getWidth() || $newHeight !== $this->getHeight()) { // resize
-			$newImage = static::fromBlank($newWidth, $newHeight, self::RGB(0, 0, 0, 127))->getImageResource();
+			$newImage = static::fromBlank($newWidth, $newHeight, self::rgb(0, 0, 0, 127))->getImageResource();
 			imagecopyresampled(
 				$newImage, $this->image,
 				0, 0, 0, 0,
@@ -450,6 +450,7 @@ public function place(self $image, $left = 0, $top = 0, int $opacity = 100)
 
 		$output = $input = $image->image;
 		if ($opacity < 100) {
+			$tbl = [];
 			for ($i = 0; $i < 128; $i++) {
 				$tbl[$i] = round(127 - (127 - $i) * $opacity / 100);
 			}

src/Utils/ObjectHelpers.php

@@ -126,6 +126,7 @@ public static function getMagicProperties(string $class): array
 
 	/**
 	 * Finds the best suggestion (for 8-bit encoding).
+	 * @param  (\ReflectionFunctionAbstract|\ReflectionParameter|\ReflectionClass|\ReflectionProperty|string)[]
 	 * @internal
 	 */
 	public static function getSuggestion(array $possibilities, string $value): ?string
@@ -163,7 +164,7 @@ private static function parseFullDoc(\ReflectionClass $rc, string $pattern): arr
 
 	/**
 	 * Checks if the public non-static property exists.
-	 * @return bool|'event'
+	 * @return bool|string returns 'event' if the property exists and has event like name
 	 * @internal
 	 */
 	public static function hasProperty(string $class, string $name)