Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add support for caminoi::Utf8PathBuf #99

Open
AzHicham opened this issue Jun 26, 2024 · 2 comments
Open

[feature] Add support for caminoi::Utf8PathBuf #99

AzHicham opened this issue Jun 26, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@AzHicham
Copy link

Hello,

Thank you for you work.
Would it be possible to add under a feature flag support for camino::Utf8Path ?

I can create the PR if you want.

@rlebran
Copy link
Contributor

rlebran commented Jun 27, 2024

Hi !

I see multiple ways of doing it (works for any type really):

  • adding it in both schemars and apistos (might take some times)
  • adding it in apistos only using the ApiType derive macro combined with the TypedSchema trait (never been made inside apistos before but we can have a look at it)
  • adding it in apistos only by creating a new type around it and manually implementing JsonSchema for it as well as ApiComponent which means this new type would be the one apistos consumer would have to use
  • implement support for it in your codebase only using one of the 2 methods above

I would love to see a PR if you pick the second or the third method !

@rlebran rlebran added the enhancement New feature or request label Jun 27, 2024
@AzHicham
Copy link
Author

Thank you for your answer.
I'll try to work on it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants