toggle update event has to be sent by the parent

as they don't get navigation focus

Author: neu-rah

examples/esp8266/WebMenu/platformio.ini

@@ -30,8 +30,8 @@ build_flags =
   -DMENU_ASYNC
   -DMENU_FMT_WRAPS
   -DMENU_IDLE_BKGND
-  -DNO_MENU_DEBUG
-  -DNO_WEB_DEBUG
+  -DMENU_DEBUG
+  -DWEB_DEBUG
   -DMENU_SSID="\"r-site.net\"" -DMENU_PASS="\"rsite.2011\""
 src_build_flags = !echo "-Wno-write-strings -Wno-reorder -Wno-strict-aliasing -Wno-sign-compare -DLOC="$PLATFORMIO_LOC
 

library.properties

@@ -1,5 +1,5 @@
 name=ArduinoMenu library
-version=4.15.6
+version=4.15.7
 author=Rui Azevedo, [email protected]
 maintainer=neu-rah, [email protected]
 sentence=Generic menu/interactivity system

src/items.cpp

@@ -96,10 +96,11 @@ Used prompt::printTo(navRoot &root,bool sel,menuOut& out, idx_t idx,idx_t len,id
     _trace(Serial<<"root.path[lvl].sel==n:"<<(root.path[lvl].sel==n)<<endl);
     _trace(Serial<<"root.path[lvl+1].target==&operator[](n))):"<<(root.path[lvl+1].target==&operator[](n))<<endl);
     _trace(Serial<<"operator[](n).type()==toggleClass:"<<(operator[](n).type()==toggleClass)<<endl);
+    bool toggleUpdate=operator[](n).type()==toggleClass&&strchr(uri,'/');
     if (!(
         //if updating a toggle to not toggle the value, was deffault action
         //but as we can't enter toggles this action would be preceeding every update otherwise.
-        (operator[](n).type()==toggleClass&&strchr(uri,'/'))
+        toggleUpdate
         ||(root.level>lvl&&root.path[lvl].sel==n&&root.path[lvl+1].target==&operator[](n))
       )) {
       _trace(Serial<<"menuNode, escTo "<<lvl<<endl);
@@ -108,7 +109,10 @@ Used prompt::printTo(navRoot &root,bool sel,menuOut& out, idx_t idx,idx_t len,id
       root.doNav(navCmd(idxCmd,n));
     }
     _trace(Serial<<"menuNode, proceed async"<<endl);
-    return operator[](n).async(uri,root,lvl+1);
+    operator[](n).async(uri,root,lvl+1);
+    if (toggleUpdate)
+      root.node().event(root.useUpdateEvent?updateEvent:enterEvent,n);
+    return true;
   }
   const char* navTarget::typeName() const {return "navTarget";}
 #endif

src/itemsTemplates.cpp

@@ -112,15 +112,18 @@ namespace Menu {
         _trace(Serial<<"selecting value by index!"<<endl);
         idx_t n=menuNode::parseUriNode(uri);
         _trace(MENU_DEBUG_OUT<<"n:"<<n<<" sel:"<<root.path[lvl].sel<<endl);
-        menuVariant<T>::sync(n);//sync to index!
-        root.node().event(root.useUpdateEvent?updateEvent:enterEvent);
+        menuVariant<T>::sync(n);//sync to index n!
+        // root.node().event(root.useUpdateEvent?updateEvent:enterEvent);
         return true;
       }
       //if not by index then do the toggle
       _trace(Serial<<"toggle proceed..."<<endl);
-      bool r=prompt::async(uri,root,lvl);
-      root.node().event(root.useUpdateEvent?updateEvent:enterEvent);
-      return r;
+      // root.doNav(navCmd(enterCmd));
+      // return true;
+      // bool r=prompt::async(uri,root,lvl);
+      // root.node().event(root.useUpdateEvent?updateEvent:enterEvent);
+      // return r;
+      return prompt::async(uri,root,lvl);
     }
   #endif