-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question on crf layer, why loop through batch before crf layer? #37
Comments
Hi @lkqnaruto , By interleaved zeros and ones, I meant a mask like For instance, suppose we have these tokens: The mask is different for each sequence of the batch and have different lengths (sum of 1's), so this masking is not trivial to do without an explicit for loop. |
Thank you for the reply, a follow up question: Why we have to loop through each batch before crf? I think crf package can handle batch-wise calculation. |
Hi @fabiocapsouza, I'm experimenting with different ways of subword handling for CRF layer. Why have you chosen to just take first subtoken? Wouldn't some sort of pooling of subword representations work better? I would greatly appreciate if you could share your thoughts on the matter! |
Hi @ViktorooReps , |
I checked out the code, where you said :
Can you explain a little bit on that? I'm still confused what you mean here. What does it mean by "interleaved zeros and ones"?
Thank you
The text was updated successfully, but these errors were encountered: