Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detaching from a build job leads to the success build message #524

Open
eviltwinhans opened this issue Jun 6, 2022 · 2 comments
Open

Detaching from a build job leads to the success build message #524

eviltwinhans opened this issue Jun 6, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@eviltwinhans
Copy link

eviltwinhans commented Jun 6, 2022

Description

Detaching from a build job evokes the success build message

STR

  1. In CLI, run neuro-flow image build
  2. Detach from the job: ctrl+p-ctrl+q
  3. You get the message INFO: Successfully built image:...
@eviltwinhans eviltwinhans added the bug Something isn't working label Jun 6, 2022
@YevheniiSemendiak
Copy link
Collaborator

I think this might be fixed on neuro-extras side.

@YevheniiSemendiak YevheniiSemendiak transferred this issue from neuro-inc/neuro-flow Jun 6, 2022
@YevheniiSemendiak
Copy link
Collaborator

The easiest way I see atm is to check the job status using neuro_sdk here and return some exitcode If job is still running. Afterward, we could do a warning: detached from job STDOUT here

We could also parse the logs of the subprocess and catch the Terminal was detached but job is still running message, but this is less reliable as for me.
We could also catch-and-transfer detach commands, but this is overkill.
wdyt, @andriihomiak?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants