Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can we launch a partially complete app #308

Closed
2 tasks
Tracked by #251 ...
surchs opened this issue Jan 11, 2023 · 3 comments
Closed
2 tasks
Tracked by #251 ...

can we launch a partially complete app #308

surchs opened this issue Jan 11, 2023 · 3 comments
Assignees
Milestone

Comments

@surchs
Copy link
Contributor

surchs commented Jan 11, 2023

With #251 done, the app should now partially work again - at least up to the categorization page. Here we want to make sure that:

  • we can launch the app even though part of it relies on not-yet-implemented store methods (e.g. annotation page)
  • OR: understand how we can partially launch the app in the state it is in now

This can be closed when the current app state can be successfully launched via npm run dev locally, even if the UI or functionality doesn't work correctly yet.

@surchs surchs added this to the v0.1.0 milestone Jan 11, 2023
@jarmoza jarmoza self-assigned this Jan 16, 2023
@jarmoza
Copy link
Contributor

jarmoza commented Jan 19, 2023

To briefly comment on the work on this issue in branch jarmoza-308, the goal of this task needs to be amended to have most of the primary functionality be complete from index page to the categorization page in order to move on to refactoring the e2e tests for those pages.

The three primary subtasks for #308 are as follows:

  • Functional index page (uploading data table and data dictionary, ensuring categorization page access requirements are updated)
  • Functional navbar and next page buttons - updated for the store refactor
  • Functional categorization page with working category-select-table and column-linking-table to enable access to the annotation page

These require hooking up components that were not necessarily fully sutured together via the phase 1 of the store refactor (via missing calls, field/method renames, etc.), but also the addition of missing store fields and methods necessary for hooking those components/pages together.

@jarmoza
Copy link
Contributor

jarmoza commented Jan 20, 2023

At the beginning of this work re: PR #318, the tool was not loading in the browser because the old store index.js did not mesh up with the code for the landing page and its components.

This was initially overcome via Unit test imports changed to index.js, Index.js refactor file swap + initial changes,

@jarmoza
Copy link
Contributor

jarmoza commented Jan 26, 2023

Closed by #327

@jarmoza jarmoza closed this as completed Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants