Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is there something like isort for js? #354

Open
surchs opened this issue Feb 9, 2023 · 6 comments
Open

is there something like isort for js? #354

surchs opened this issue Feb 9, 2023 · 6 comments
Labels
_flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again good first issue Good issue for a new contributor. importance:low We are not actively pursuing this item, it may be addressed when there is extra capacity. maint:refactor Simplifying or restructuring existing code or documentation. PR welcome Issue that is not an internal priority, but external PRs to address it are welcome. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs

Comments

@surchs
Copy link
Contributor

surchs commented Feb 9, 2023

I notice we sometimes have diffs to re-sort object keys and such things. Is there maybe some tool we can configure to go through the whole codebase once to make the appropriate changes, and to then keep on top of this - e.g. as part of a pre-commit check?

@surchs surchs added importance:low We are not actively pursuing this item, it may be addressed when there is extra capacity. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs maint:refactor Simplifying or restructuring existing code or documentation. labels Feb 9, 2023
@jarmoza
Copy link
Contributor

jarmoza commented Feb 9, 2023

@surchs I believe we can do this by adding the "sort-keys" rule to the eslint rc file, and then by installing/configuring this plugin.

@surchs
Copy link
Contributor Author

surchs commented Feb 9, 2023

Cool! I'm in favour of adopting the eslint rule to keep things consistent. I'm less clear about the tool, it looks not very widely adopted / maintained. I could imagine that having the rule enabled and configured to show up in the IDE (and during pre-commit) might be sufficient here. wdyt?

@jarmoza
Copy link
Contributor

jarmoza commented Feb 9, 2023

'sort-keys' definitely works. I tried it out before I commented earlier. I can see it being annoying to the coder to do it manually. I'm alright with it though myself.

That said, I don't know if eslint --fix will alphabetize it. If so, then that's even better.

@github-actions
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Mar 12, 2023
@github-actions
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@surchs surchs added good first issue Good issue for a new contributor. PR welcome Issue that is not an internal priority, but external PRs to address it are welcome. and removed _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again labels Dec 5, 2023
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again good first issue Good issue for a new contributor. importance:low We are not actively pursuing this item, it may be addressed when there is extra capacity. maint:refactor Simplifying or restructuring existing code or documentation. PR welcome Issue that is not an internal priority, but external PRs to address it are welcome. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs
Projects
Status: No status
Development

No branches or pull requests

2 participants