Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure apiQueryURL ends in slash in the entire app, not just when sending a query #22

Closed
surchs opened this issue Dec 15, 2023 · 2 comments
Labels
bug:functional Functional defects resulting from feature changes. type:bug Defects in shipped code and fixes for those defects

Comments

@surchs
Copy link
Contributor

surchs commented Dec 15, 2023

in #212 we added an automatic adding of a slash to the query URL:

https://github.com/neurobagel/old-query-tool/blob/81a690fd74e0c08a95079a26622f4d4ed018517a/components/QueryForm.vue#L153-L158

but this only affects the sending of the queries, not the overall apiQueryURL (e.g. for listing the nodes and options):

https://github.com/neurobagel/old-query-tool/blob/81a690fd74e0c08a95079a26622f4d4ed018517a/nuxt.config.js#L55-L58

We should make sure we add a slash if one is missing at the deepest level (maybe even immediately when we read the .env file)

@surchs surchs added bug:functional Functional defects resulting from feature changes. type:bug Defects in shipped code and fixes for those defects labels Dec 15, 2023
@alyssadai alyssadai added the flag:schedule Flag issue that should go on the roadmap or backlog. label Feb 12, 2024
@alyssadai alyssadai transferred this issue from neurobagel/old-query-tool Feb 12, 2024
@alyssadai alyssadai removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Feb 12, 2024
@samadpls
Copy link
Contributor

samadpls commented Mar 7, 2024

Hi @surchs , Following up on the previous pull request, what additional requirements need to be addressed for this issue? 😋

@rmanaem
Copy link
Contributor

rmanaem commented Mar 7, 2024

Hi @samadpls,
This issue has been addressed in the new tool but we currently don't have a test for it. If you're interested in writing a test for it please see #61

@rmanaem rmanaem closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:functional Functional defects resulting from feature changes. type:bug Defects in shipped code and fixes for those defects
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants