Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for ways to test result card styling without the Result Container #34

Open
surchs opened this issue Feb 23, 2024 · 0 comments
Open
Labels
someday Not a priority right now, but we want to keep this around to think or discuss more.

Comments

@surchs
Copy link
Contributor

surchs commented Feb 23, 2024

the test is more like a mini-integration test. To check if download button styles correctly if any dataset is selected, you could just feed the selectedDatasets prop non-empty. Here you're testing that step, but also the correct event handling for a checked dataset card, and then whether the ResultContainer processes this info correctly. So 3 steps in one. The goal would be to really just test one thing

Originally posted by @surchs in #31 (comment)

@surchs surchs added the someday Not a priority right now, but we want to keep this around to think or discuss more. label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
someday Not a priority right now, but we want to keep this around to think or discuss more.
Projects
None yet
Development

No branches or pull requests

1 participant