Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to deploy-on-release #106

Closed
2 of 3 tasks
surchs opened this issue Sep 18, 2024 · 2 comments
Closed
2 of 3 tasks

Move to deploy-on-release #106

surchs opened this issue Sep 18, 2024 · 2 comments
Labels
maint:process Improvement to internal processes type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs

Comments

@surchs
Copy link
Contributor

surchs commented Sep 18, 2024 •
edited by rmanaem
Loading

Like we learned with the annotation tool (neurobagel/annotation_tool#790): deploying to prod from every main merge is risky. Let's not do that anymore.

Instead

  • Change our deployment process to only run on a release
  • Find a way to have a running "nightly" version with a persistent name (i.e. not the staging previews, but maybe netlify works)
  • Setup / carry over the auto-release workflow from other projects
@surchs surchs added type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs maint:process Improvement to internal processes flag:schedule Flag issue that should go on the roadmap or backlog. labels Sep 18, 2024
@rmanaem rmanaem transferred this issue from neurobagel/query-tool Sep 23, 2024
@rmanaem rmanaem removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Sep 24, 2024
@rmanaem
Copy link
Collaborator

rmanaem commented Oct 3, 2024

This tool currently doesn't have a release workflow. That needs to be added either as part of this issue or another issue to proceed.

@surchs
Copy link
Contributor Author

surchs commented Oct 17, 2024

The "nightly" builds are already happening and going to https://upload-ui.netlify.app/. So we can close the issue

@surchs surchs closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maint:process Improvement to internal processes type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs
Projects
Neurobagel
Status: Review - Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@surchs @rmanaem