Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spatial distance curve metric redundancy #373

Open
tathey1 opened this issue Dec 20, 2022 · 5 comments
Open

spatial distance curve metric redundancy #373

tathey1 opened this issue Dec 20, 2022 · 5 comments
Labels
good first issue Good for newcomers no-issue-activity

Comments

@tathey1
Copy link
Member

tathey1 commented Dec 20, 2022

we implement sd/ssd in both here: https://github.com/neurodata/brainlit/blob/develop/brainlit/algorithms/connect_fragments/trace_evaluation.py

and here: https://github.com/neurodata/brainlit/blob/develop/brainlit/utils/Neuron_trace.py

I think it should be a static (not a class) method, and it should only be defined once.
@tathey1 tathey1 added the good first issue Good for newcomers label Dec 20, 2022
@github-actions
Copy link

Stale issue message

@anviimishra
Copy link

I'm interested in helping with this!

@tathey1
Copy link
Member Author

tathey1 commented Sep 7, 2023

great, i think that maybe we should remove it from Neuron_trace, and make sure that we switch every time it is called to the version in trace_evaluation. What do you think @anviimishra?

@tathey1
Copy link
Member Author

tathey1 commented Sep 7, 2023

spatial distance is described in methods here

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers no-issue-activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tathey1 @anviimishra