Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaData["Number of Regions"] is inconsistent #54

Open
shnizzedy opened this issue Jun 17, 2024 · 0 comments
Open

MetaData["Number of Regions"] is inconsistent #54

shnizzedy opened this issue Jun 17, 2024 · 0 comments

Comments

@shnizzedy
Copy link

Contribution Criteria § File 2: Atlas Information says

Number of Regions: The number of regions defined by the atlas, not including empty space. Will be calculated if not provided

and that is accurate in the Atlas Info Summary table in all of the atlases I've inspected, but in the JSON files, many do include empty space in the count, so the number in the MetaData["Number of Regions"] field in the JSON is one more than the number in the # Regions column in the README.

Relatedly,

js_contents['rois'][str(0)] = {"label": "empty", "center":None}
for (k, v) in csv_dict.items():
k=int(k)
try:
js_contents['rois'][str(k)] = {"label": v, "center": parcel_centers[k], "size":int(size[k])}
roi_sum=roi_sum+size[k]
count=count+1
except KeyError:
js_contents['rois'][str(k)] = {"label": v, "center": None, "size": None}
except TypeError:
js_contents['rois'][str(k)] = {"label": v, "center": None, "size": None}
will include the region with index 0 in the count if that index is included in the label CSV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant