-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transforming coordinates and images #3
Comments
Good question. We can iterate, but I guess my initial feeling is that things should be left in their native space in a |
That makes sense, especially for users planning to perform smaller meta-analyses fairly rarely. For those interested in running large numbers of meta-analyses with different samples, shifting all of the transformations to the dataset selection phase would be problematic. I don't know how much you want to design As a compromise, we could release the full combined database in its raw form, with coordinates and images in whatever space they were originally provided in (ignoring, for the moment, surfaces and connectivity matrices), along with an MNI 2mm version with all of the data in the same space. This way, rapid, large-scale analyses can be performed on the resampled version of the database, while more content-oriented users can transform data to whatever space/resolution they want (MNI 1mm, Talairach, etc.) during dataset selection. And, of course, all of the meta-analytic algorithms would be agnostic to space. In terms of the code, I think this means that we'll want the How does that sound? |
I'm not sure if this belongs in a separate issue, but I'm coming up against a bit of a wall when it comes to images. In order to push transforming images to the same space until dataset selection, I think we'll need to include both a set of templates/masks and transforms between those templates in the package resources. That way, users can just specify their target when they call We'll need some way to apply the transforms as well (e.g., FSL), which means we'll need a Docker image for the package, right? To get a list of templates and their names, I was thinking we could use the NIDM Results specification. I haven't looked too deeply into the specification beyond the coordinate system names, but it seems like we should make NiMARE as compatible with it as possible. What do you think? |
I think we've come to a consensus regarding when and how to transform coordinates in other threads, so I'm going to close this now. |
@tyarkoni At what point should the coordinates and images be transformed to the same template? I know you had some thoughts on that, but I can't remember the specifics. I'm currently working on a function to download images from NeuroVault and coordinates from NeuroSynth (or maybe that should be brainspell) and merge the two into one
Dataset
object, and I'm not sure if I should transform everything into the same space as part of compiling the database or if I should leave it until a later step (e.g., the meta-analysis stage).The text was updated successfully, but these errors were encountered: