[ENH] Support Dataset transformations in kernel transformers #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't mask MA maps when return_type is dataset. - Try to load MA maps from dataset before generating them.
I'm not sure why the bug popped up now though. Maybe it was a random seed-related issue?
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
==========================================
- Coverage 77.18% 77.15% -0.04%
==========================================
Files 38 38
Lines 3678 3817 +139
==========================================
+ Hits 2839 2945 +106
- Misses 839 872 +33
Continue to review full report at Codecov.
|
Also fix a masking bug.
|
I'm going to hold off on abstracting things to the base class until later. |
This was referenced Aug 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41 and closes #307 and references #195.
Changes proposed in this pull request:
Dataset.basepathand the parameters of the transformer, and stores the path in theDataset.imagesattribute.nimare.stats.null_to_p(). Values outside the range of the null distribution (i.e., p = 0) are now cropped down to epsilon for float.To do:
Something to perhaps keep an eye on is that there was a new overflow error in one of the MKDA tests. Since these changes shouldn't impact behavior, I think the new error (which reflects a bug in
null_to_p), probably stems from a random seed thing.