Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set n_iters=10000 default only for null_method="montecarlo" #801

Closed
JulioAPeraza opened this issue May 12, 2023 · 0 comments · Fixed by #803
Closed

Set n_iters=10000 default only for null_method="montecarlo" #801

JulioAPeraza opened this issue May 12, 2023 · 0 comments · Fixed by #803
Labels
bug Issues noting problems and PRs fixing those problems.

Comments

@JulioAPeraza
Copy link
Collaborator

Summary

It is a little confusing to set n_iters=10000 as the default even when a null_method="approximate" is used.

Additional details

  • NiMARE version: main

What were you trying to do?

This is also related to the reports module #773 when I tried to show the parameters used to fit the estimator.

What did you expect to happen?

Shows n_iters=None when null_method="approximate" is used.

What actually happened?

Shows n_iters=10000 when null_method="approximate" is used.

Fixing the bug

self.n_iters = None if null_method == "approximate" else n_iters or 10000
@JulioAPeraza JulioAPeraza added the bug Issues noting problems and PRs fixing those problems. label May 12, 2023
@JulioAPeraza JulioAPeraza mentioned this issue May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues noting problems and PRs fixing those problems.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set n_iters defaults only for estimators with null_method="montecarlo" JulioAPeraza/NiMARE
1 participant
@JulioAPeraza