Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the ale_sleuth_workflow function in favor of CBMAWorkflow and PairwiseCBMAWorkflow? #849

Closed
JulioAPeraza opened this issue Dec 11, 2023 · 0 comments · Fixed by #851
Closed

Deprecate the ale_sleuth_workflow function in favor of CBMAWorkflow and PairwiseCBMAWorkflow? #849

JulioAPeraza opened this issue Dec 11, 2023 · 0 comments · Fixed by #851
Labels
deprecation Classes/functions/behaviors flagged for later removal. question Further information is requested refactoring Requesting changes to the code which do not impact behavior workflows Issues related to the workflows module

Comments

@JulioAPeraza
Copy link
Collaborator

Now that we added CBMAWorkflow and PairwiseCBMAWorkflow, would it be OK to remove the ale_sleuth_workflow?
I added a deprecation warning about removing the function for the next version.
However, I was wondering if it would be helpful to keep the function (which only requires sleuth files) and just refactor it using the new CBMAWorkflow and PairwiseCBMAWorkflow classes.
@JulioAPeraza JulioAPeraza added question Further information is requested refactoring Requesting changes to the code which do not impact behavior workflows Issues related to the workflows module deprecation Classes/functions/behaviors flagged for later removal. labels Dec 11, 2023
@JulioAPeraza JulioAPeraza mentioned this issue Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecation Classes/functions/behaviors flagged for later removal. question Further information is requested refactoring Requesting changes to the code which do not impact behavior workflows Issues related to the workflows module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate ale_sleuth_workflow in favor of CBMAWorkflow and PairwiseCBMAWorkflow JulioAPeraza/NiMARE
1 participant
@JulioAPeraza