Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shaken as request without attest #166

Open
di-shi opened this issue Jan 24, 2023 · 4 comments
Open

shaken as request without attest #166

di-shi opened this issue Jan 24, 2023 · 4 comments

Comments

@di-shi
Copy link

di-shi commented Jan 24, 2023

The test bed accepts SHAKEN AS request without attest and puts attest A in token. It is against RFC/ATIS/3GPP.

Test on 1/24/2023.

@kpolitz
Copy link
Contributor

kpolitz commented Feb 9, 2023

Acknowledged. This is likely a default AS configuration if "attest" is not provided. Assume you sent something like below. Please confirm and I will check with development. Table V.2.5.2-1a does indicate that "attest" is Mandatory for a "shaken" PASSporT AS request.

{"ppt":"shaken",
"orig":{"tn":"sip:[email protected]"},
"dest":{"tn":["sip:[email protected]"]},
"iat":1675960788,
"origid":"2088448c-718e-4930-be5d-0ec9b25d2f00"}

@di-shi
Copy link
Author

di-shi commented Feb 9, 2023

The test case uses "aattest". Same as without "attest"

@kpolitz
Copy link
Contributor

kpolitz commented Feb 16, 2023

"attest" and "origid" are mandatory (expected) parameters for "shaken" PASSporT signing. However, if not provided, a server implementation may or may not choose to use other configured information to assign an "attest" and / or "origid" value. In this case, the unrecognized parameter name, "aatest", is ignored and other server configuration information was used to set an "attest" value. Please let us know if we can close this Issue. Thanks.

@di-shi
Copy link
Author

di-shi commented Feb 16, 2023

As attest is mandatory according to 3GPP, it is reasonable to reject the request. Let's see what other SHAKEN implementations say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants