Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up of fitting unit test #291

Open
peterfpeterson opened this issue Jan 21, 2020 · 0 comments
Open

Clean-up of fitting unit test #291

peterfpeterson opened this issue Jan 21, 2020 · 0 comments

Comments

@peterfpeterson
Copy link
Member

peterfpeterson commented Jan 21, 2020

There is still a fair amount of cleaning up that would make this easier to follow/modify:

  1. Create a method for verifying Gaussian parameters, verify_gaussian(FitResult, height, center, sigma) which would use np.testing.assert_allclose to check the raw peak parameters.
  2. Create a method for verifying pseudo-Voigt parameters, verify_pseudovoigt(FitResult, intensity, center, fwhm, mixing) to check the raw parameters
  3. The checks for native vs effective parameters as that is already covered by more complete tests in test_peak_collection that are part of this.
  4. The checks for cost can also dropped

This is a follow-on to #260, but should not be started until #292 is merged in.

peterfpeterson added a commit that referenced this issue Jan 21, 2020
Some peaks were being used with a height of .2 and noise of +-2. This
reduces the noise to be smaller than the peak height which makes the
tests pass more regularly. Also remove checks for the chisq.

Refs #291
peterfpeterson added a commit that referenced this issue Jan 21, 2020
Some peaks were being used with a height of .2 and noise of +-2. This
reduces the noise to be smaller than the peak height which makes the
tests pass more regularly. Also remove checks for the chisq.

Refs #291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants