Rename 'sample' to 'peak' in auto-reduction code #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the code to standardize terminology by replacing 'sample' with 'peak'. This change affects variable names, comments, and documentation strings to improve clarity and consistency in the codebase. Signed-off-by: Jose Borreguero <[email protected]>
Updated form name from ReductionConfigurationREFMForm to ReductionConfigurationREF_MForm across views and tests to maintain consistency and clarity in naming conventions. Also changed references from "sample" to "peak" for better accuracy in context. Signed-off-by: Jose Borreguero <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #192 +/- ##
=======================================
Coverage 77.77% 77.77%
=======================================
Files 54 54
Lines 4720 4720
=======================================
Hits 3671 3671
Misses 1049 1049 ☔ View full report in Codecov by Sentry. |
Renamed the target for creating the conda environment to "create/conda" to align with naming conventions. Also provided an alternative command for creating the environment using mamba. Signed-off-by: Jose Borreguero <[email protected]>
Enhanced the documentation to give clearer steps on rebuilding wheels. Added instructions to run 'make all' after cleaning existing wheels to ensure complete rebuild. Signed-off-by: Jose Borreguero <[email protected]>
Commented out the line that writes response content to a file for browser inspection. This change ensures that the code is only executed when debugging, preventing accidental file creation during regular test runs. Signed-off-by: Jose Borreguero <[email protected]>
Updated the comment to provide clearer instructions on how to inspect the response content using a browser. This change enhances developer clarity when debugging response outputs. Signed-off-by: Jose Borreguero <[email protected]>
Replaced <span> tags with <label> tags in multiple sections of the configuration_ref_m.html template. This modification ensures better accessibility compliance by clearly linking labels with their corresponding input fields. Signed-off-by: Jose Borreguero <[email protected]>
|
I deployed locally and the form has been updated to replace "sample" with "peak" and the form allows configuring up to three peaks: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Refactored the code to standardize terminology by replacing 'sample' with 'peak' regarding post-processing for
instrument REF_M.
Check all that apply:
Added unit testsAdded integration tests(If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without failReferences:
Manual test for the reviewer
Deploy the app locally:
Wait until the docker images are built and services started. Then, point your browser to http://localhost/reduction/ref_m/ and verify reduction settings for the three Peaks are present.
Check list for the reviewer