Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded static files finder #198

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

rosswhitfield
Copy link
Member

@rosswhitfield rosswhitfield commented Nov 21, 2024

Description of the changes

This will fix some warnings when starting up WebMon.

FileSystemFinder finds all the files we need, having AppDirectoriesFinder included was just causing some files to be found multiple times.

This should fix all the "Found another file with the destination path" warnings seen when webmon starts.

If you look at the logs docker logs data_workflow-webmon-1 the warnings should be gone.

You can also verify that all the needed static files are still copied by first removing the volume docker volume rm data_workflow_web-static, then start webmon and check everything is still working correctly.

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

FileSystemFinder finds all the files we need, having AppDirectoriesFinder included was just causing the same files to be found multiple times
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.78%. Comparing base (de13b21) to head (add2bc9).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #198   +/-   ##
=======================================
  Coverage   77.78%   77.78%           
=======================================
  Files          54       54           
  Lines        4708     4708           
=======================================
  Hits         3662     3662           
  Misses       1046     1046           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rosswhitfield rosswhitfield merged commit e3efb4e into next Nov 21, 2024
4 checks passed
@rosswhitfield rosswhitfield deleted the fix_found_duplicate_staticfiles branch November 21, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants