Remove unneeded static files finder #198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
This will fix some warnings when starting up WebMon.
FileSystemFinder
finds all the files we need, havingAppDirectoriesFinder
included was just causing some files to be found multiple times.This should fix all the "Found another file with the destination path" warnings seen when webmon starts.
If you look at the logs
docker logs data_workflow-webmon-1
the warnings should be gone.You can also verify that all the needed static files are still copied by first removing the volume
docker volume rm data_workflow_web-static
, then start webmon and check everything is still working correctly.Check all that apply:
References:
Manual test for the reviewer
(Instructions for testing here)
Check list for the reviewer