Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tool everywhere #7

Merged
merged 12 commits into from
Dec 2, 2024
Merged

Rename tool everywhere #7

merged 12 commits into from
Dec 2, 2024

Conversation

mpatrou
Copy link
Collaborator

@mpatrou mpatrou commented Nov 25, 2024

Short description of the changes:

The name is updated to hyspecppt in every src, test, doc and build-related files.
Other improvements are added, too.

Long description of the changes:

  • It updates hyspecppt in files, classes, logging, imports, tests, documentation, code coverage, default urls, build-related files and github actions.
  • additional test for invalid command argument
  • documentation update with newer requirement changes
  • readthedocs update and project import

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

[Story] Rename Hyspec Polarization Planning Tool

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.50%. Comparing base (decafcc) to head (18fb5d2).

Files with missing lines Patch % Lines
src/hyspecppt/hyspecppt.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             next       #7   +/-   ##
=======================================
  Coverage   90.50%   90.50%           
=======================================
  Files           8        8           
  Lines         158      158           
=======================================
  Hits          143      143           
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpatrou mpatrou requested a review from KyleQianliMa November 27, 2024 14:26
docs/source/design/hyspecpptfields.rst Outdated Show resolved Hide resolved
docs/source/design/hyspecpptfields.rst Outdated Show resolved Hide resolved
@KyleQianliMa
Copy link
Collaborator

All looks good! Approved

@AndreiSavici AndreiSavici merged commit 7d920a8 into next Dec 2, 2024
3 checks passed
@AndreiSavici AndreiSavici deleted the rename_tool branch December 2, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants