Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Documentation and Code Improvements #8

Merged
merged 29 commits into from
Dec 11, 2024
Merged

Conversation

mpatrou
Copy link
Collaborator

@mpatrou mpatrou commented Dec 2, 2024

It includes the design documentation and some additional improvements.

Short description of the changes:

  • documentation: class, MVP, workflows, etc
  • PySide6 issue fixed
  • src/class renaming

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.50%. Comparing base (18fb5d2) to head (c0668b7).
Report is 6 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next       #8   +/-   ##
=======================================
  Coverage   90.50%   90.50%           
=======================================
  Files           8        8           
  Lines         158      158           
=======================================
  Hits          143      143           
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AndreiSavici AndreiSavici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

docs/source/design/hyspecpptclasses.rst Outdated Show resolved Hide resolved
docs/source/design/hyspecpptclasses.rst Outdated Show resolved Hide resolved
docs/source/design/hyspecpptclasses.rst Outdated Show resolved Hide resolved
docs/source/design/hyspecpptclasses.rst Outdated Show resolved Hide resolved
@mpatrou mpatrou marked this pull request as draft December 3, 2024 16:57
@mpatrou mpatrou marked this pull request as ready for review December 6, 2024 03:37
Copy link
Member

@AndreiSavici AndreiSavici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes required

docs/source/design/hyspecpptclasses.rst Show resolved Hide resolved
docs/source/design/hyspecpptclasses.rst Outdated Show resolved Hide resolved
docs/source/design/hyspecpptclasses.rst Outdated Show resolved Hide resolved
@AndreiSavici AndreiSavici merged commit ee8dce0 into next Dec 11, 2024
3 checks passed
@AndreiSavici AndreiSavici deleted the design_docs branch December 11, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants