Sandbox for Defect 7743 #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the skip marker from the 'test_missing_cross_section' test, enabling it to run. Added a cleanup step to delete 'main_window' at the end of the test to ensure proper resource deallocation. Signed-off-by: Jose Borreguero <[email protected]>
Corrected the spacing in the skip comment decorator for clarity. Ensured proper syntax to maintain clean coding standards and improve readability in the CI pipeline. Signed-off-by: Jose Borreguero <[email protected]>
Ensure UI updates are processed during the test execution. This change is necessary for the QApplication to handle pending events, which ensures the test reflects accurate UI behavior. Signed-off-by: Jose Borreguero <[email protected]>
Removed an unnecessary reflectivity threshold assertion and redundant temporary variables from the test_missing_cross_section.py file. Streamlined the test to check intensity changes directly and cleaned up the code by removing unused QApplication process events calls. Signed-off-by: Jose Borreguero <[email protected]>
Introduce debug print statements to log the reflectivity threshold value and individual test values. This will help in diagnosing potential issues with the reflectivity checks during test execution. Signed-off-by: Jose Borreguero <[email protected]>
Re-enable the previously commented-out assertion that checks if all test values are below the reflectivity threshold. This ensures the test suite correctly verifies the reflectivity criteria. Signed-off-by: Jose Borreguero <[email protected]>
Replaced the debug prints for the `test` variable with detailed prints for `data_y` values in the reflectivity curve check. This ensures that we are logging the correct data for debugging and improves clarity in the reflectivity verification process. Signed-off-by: Jose Borreguero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work:
Check all that apply:
(if not, provide an explanation in the work description)
References:
Manual test for the reviewer
(instructions to set up the environment)
Check list for the reviewer
or an explanation is provided as to why release notes are unnecessary