Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify some portion of the code #99

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Jul 24, 2024

Description of the changes

References:

Manual test for the reviewer

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Check list for the pull request

  • source refactored/incremented
  • tests for my changes
  • updated the documentation accordingly

Signed-off-by: Jose Borreguero <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.43%. Comparing base (0778686) to head (e2b4871).

Additional details and impacted files
@@           Coverage Diff           @@
##             next      #99   +/-   ##
=======================================
  Coverage   35.43%   35.43%           
=======================================
  Files          30       30           
  Lines        6067     6067           
=======================================
  Hits         2150     2150           
  Misses       3917     3917           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants