[nri-bundle] [newrelic-logging] feat: added support for templated cluster name value #1287
+9
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ndrissi
approved these changes
Feb 19, 2024
pcanilho
force-pushed
the
feature/support-templated-cluster-name
branch
from
d36004a
to
a46b770
Compare
isometry
approved these changes
Feb 19, 2024
pcanilho
force-pushed
the
feature/support-templated-cluster-name
branch
from
a46b770
to
750af9d
Compare
| @@ -9,7 +9,7 @@ appVersion: 0.8.0 | |||
|
|
|||
| dependencies: | |||
| - name: common-library | |||
| version: 1.1.1 | |||
| version: 1.1.2 | |||
There was a problem hiding this comment.
[Just providing feedback on the chart we own]
modifying all charts at the same time is not allowed by the CI/CD
Moreover, the version was not bumped.
On the other hand, this change could be quite important and I'll leave the decision to the K8s team whether we actually want to support this use case (and then "how")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart
No.
What this PR does / why we need it:
We're deploying the chart using ArgoCD and ApplicationSets with a cluster generator. To avoid having to bake NewRelic-specific logic into our wider ArgoCD Application generator, we need support for rendering
clusteras a template variable in order to generate an appropriate value from generic values.Which issue this PR fixes
This is a new feature.
Special notes for your reviewer:
Checklist
[mychartname])Fixes #1288