@@ -56,28 +56,28 @@ All 27 global values from the nri-bundle global contract assessed:
5656
5757| Global Value | Applicable | Tested | Test File(s) |
5858| --------------| ------------| --------| --------------|
59- | cluster | Yes | ✅ Yes | global-inheritance_test.yaml (2 tests) |
59+ | cluster | Yes | Yes | global-inheritance_test.yaml (2 tests) |
6060| licenseKey | No | N/A | Webhook pods do not authenticate to New Relic |
6161| customSecretName | No | N/A | Not applicable to webhook |
6262| customSecretLicenseKey | No | N/A | Not applicable to webhook |
6363| insightsKey | No | N/A | Deprecated |
6464| provider | No | N/A | Not applicable to webhook |
65- | labels | Yes | ✅ Yes | global-inheritance_test.yaml (2 tests) |
66- | podLabels | Yes | ✅ Yes | global-inheritance_test.yaml (2 tests) |
67- | images.registry | Yes | ✅ Yes | global-inheritance_test.yaml (2 tests) |
68- | images.pullSecrets | Yes | ✅ Yes | global-inheritance_test.yaml (2 tests) |
69- | serviceAccount.create | Yes | ✅ Yes | serviceaccount-global_test.yaml (3 tests) |
70- | serviceAccount.name | Yes | ✅ Yes | serviceaccount-global_test.yaml (1 test) |
71- | serviceAccount.annotations | Yes | ✅ Yes | serviceaccount_annotations_test.yaml (2 tests) |
72- | hostNetwork | Yes | ✅ Yes | global-inheritance_test.yaml (2 tests) |
73- | dnsConfig | Yes | ✅ Yes | global-inheritance_test.yaml (2 tests) |
65+ | labels | Yes | Yes | global-inheritance_test.yaml (2 tests) |
66+ | podLabels | Yes | Yes | global-inheritance_test.yaml (2 tests) |
67+ | images.registry | Yes | Yes | global-inheritance_test.yaml (2 tests) |
68+ | images.pullSecrets | Yes | Yes | global-inheritance_test.yaml (2 tests) |
69+ | serviceAccount.create | Yes | Yes | serviceaccount-global_test.yaml (3 tests) |
70+ | serviceAccount.name | Yes | Yes | serviceaccount-global_test.yaml (1 test) |
71+ | serviceAccount.annotations | Yes | Yes | serviceaccount_annotations_test.yaml (2 tests) |
72+ | hostNetwork | Yes | Yes | global-inheritance_test.yaml (2 tests) |
73+ | dnsConfig | Yes | Yes | global-inheritance_test.yaml (2 tests) |
7474| proxy | No | N/A | Webhook does not make outbound connections |
75- | priorityClassName | Yes | ✅ Yes | global-inheritance_test.yaml (2 tests) |
76- | nodeSelector | Yes | ✅ Yes | global-inheritance_test.yaml (2 tests) |
77- | tolerations | Yes | ✅ Yes | job_serviceaccount_test.yaml (2 tests) |
78- | affinity | Yes | ✅ Yes | global-inheritance_test.yaml (2 tests) |
79- | podSecurityContext | Yes | ✅ Yes | security_context_test.yaml + job_security_context_test.yaml |
80- | containerSecurityContext | Yes | ✅ Yes | security_context_test.yaml + job_security_context_test.yaml |
75+ | priorityClassName | Yes | Yes | global-inheritance_test.yaml (2 tests) |
76+ | nodeSelector | Yes | Yes | global-inheritance_test.yaml (2 tests) |
77+ | tolerations | Yes | Yes | job_serviceaccount_test.yaml (2 tests) |
78+ | affinity | Yes | Yes | global-inheritance_test.yaml (2 tests) |
79+ | podSecurityContext | Yes | Yes | security_context_test.yaml + job_security_context_test.yaml |
80+ | containerSecurityContext | Yes | Yes | security_context_test.yaml + job_security_context_test.yaml |
8181| privileged | No | N/A | Not applicable to webhook |
8282| customAttributes | No | N/A | Not applicable to webhook |
8383| lowDataMode | No | N/A | Not applicable to webhook |
@@ -87,12 +87,6 @@ All 27 global values from the nri-bundle global contract assessed:
8787| fedramp.enabled | No | N/A | Webhook does not send data to New Relic |
8888| ** TOTAL** | ** 15/27** | ** 15/15** | ** 100% Explicit Test Coverage** |
8989
90- ## Files Modified
91-
92- - ` charts/nri-metadata-injection/templates/admission-webhooks/job-patch/serviceaccount.yaml ` - Added global serviceAccount.annotations inheritance
93- - ` charts/nri-metadata-injection/tests/webhook_test.yaml ` - Fixed invalid test assertion
94-
95- ## Upstream Integration
9690## Files Added
9791
9892- ` charts/nri-metadata-injection/tests/global-inheritance_test.yaml ` - 20 new tests for cluster, labels, podLabels, images.* , priorityClassName, hostNetwork, dnsConfig, nodeSelector, affinity
@@ -105,26 +99,24 @@ Each test validates two critical behaviors:
105992 . ** Precedence Test** : Verifies local value overrides global when both are set
106100
107101This ensures consistent precedence behavior (Local > Global > Default) across all 15 applicable global values.
108- - New annotations only apply when global.serviceAccount.annotations is set
102+
103+ ## No Breaking Changes
104+
105+ - No template modifications affecting existing functionality
106+ - No API changes
107+ - Backward compatible with existing configurations
108+ - Tests only validate existing common-library behavior
109109
110110## Build Status
111111
112112```
113- Tests: 62/62 passing (100%)
113+ Tests: 86/86 passing (100%)
114114Lint: Passing
115115Build: Successful
116116```
117117
118118## Changelog Entry
119119
120- ```
121- ## Global ServiceAccount Annotations Inheritance
122-
123- ### Added
124- - Add `global.serviceAccount.annotations` inheritance to webhook job pods
125- - Enables IAM role configuration for cloud provider authentication (IRSA, Workload Identity, Pod Identity)
126- ## Changelog Entry
127-
128120```
129121## Comprehensive Global Value Inheritance Tests
130122
0 commit comments