Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate intermittent test failures related to the ClassFileTransformer #2108

Open
jasonjkeller opened this issue Oct 25, 2024 · 2 comments

Comments

@jasonjkeller
Copy link
Contributor

jasonjkeller commented Oct 25, 2024

We occasionally see the following test failures indicating that the Java agent threw an exception when it called the ClassFileTransformer.transform method. The tests eventually pass but it's unclear why this error is occurring in the first place. We should investigate further.

com.newrelic.agent.attributes.AgentAttributeSenderTest > testCustomAttributesInTransaction FAILED
    com.newrelic.agent.tracers.SkipTracerException at AgentAttributeSenderTest.java:56
*** java.lang.instrument ASSERTION FAILED ***: "!errorOutstanding" with message transform method call failed at JPLISAgent.c line: 844
*** java.lang.instrument ASSERTION FAILED ***: "!errorOutstanding" with message transform method call failed at JPLISAgent.c line: 844
*** java.lang.instrument ASSERTION FAILED ***: "!errorOutstanding" with message transform method call failed at JPLISAgent.c line: 844
*** java.lang.instrument ASSERTION FAILED ***: "!errorOutstanding" with message transform method call failed at JPLISAgent.c line: 844
*** java.lang.instrument ASSERTION FAILED ***: "!errorOutstanding" with message transform method call failed at JPLISAgent.c line: 844
*** java.lang.instrument ASSERTION FAILED ***: "!errorOutstanding" with message transform method call failed at JPLISAgent.c line: 844

com.newrelic.agent.service.async.AsyncTransactionServiceTest > testAsyncTransactionServiceTimeout FAILED
    java.lang.AssertionError at AsyncTransactionServiceTest.java:62

The reference to the JPLISAgent means that a Java agent (not necessarily the NR Java agent) threw an exception when it called the transform method.

One theory is that the unit test flickers are due to our use of mockito-inline for mocking and it’s underlying use of a Byte Buddy Java agent. We should try to migrate away from this library for testing and see if the test flickers resolve.

@workato-integration
Copy link

@kford-newrelic kford-newrelic moved this from Triage to In Quarter in Java Engineering Board Nov 12, 2024
@kford-newrelic
Copy link
Contributor

Possible "stretch" goal for the current Q?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Quarter
Development

No branches or pull requests

2 participants