Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boot/strap to remove customer supplied agent instances and ensure the latest NR supplied one is in play #2890

Open
fallwith opened this issue Oct 3, 2024 · 1 comment
Labels
oct-dec qtr Possible FY Q3 candidate

Comments

@fallwith
Copy link
Contributor

fallwith commented Oct 3, 2024

When the APM k8s operator work was originally conducted, a conservative approach was deliberately taken to avoid colliding / clobbering any existing customer solution in play. Since then, we have received sufficient feedback encouraging us to go ahead and take ownership of any NR specific aspects of the tech stack and upgrade the APM agent to the latest k8s operator compatible version available on the container disk volume.

To align with this initiative for the Ruby agent, we need to overhaul the boot/strap system to proactively remove any instance of newrelic_rpm from the customer app supplied Bundler groups before continuing to introduce the disk volume based instance of the agent to the stack.

Presumably this can be accomplished by altering the patch of Bundler::Runtime's require method to modify the groups input arguments prior to invoking super.

Definition of done:

  • The boot/strap system has been updated
  • We have test driven confidence in the following scenarios:
    • No customer-supplied newrelic_rpm present
    • Customer-supplied newrelic_rpm present
  • Both scenarios should confirm that the agent successfully instruments customer-supplied gems
@workato-integration
Copy link

@kford-newrelic kford-newrelic added the oct-dec qtr Possible FY Q3 candidate label Oct 4, 2024
@kford-newrelic kford-newrelic moved this from Triage to In Quarter in Ruby Engineering Board Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oct-dec qtr Possible FY Q3 candidate
Projects
Status: In Quarter
Development

No branches or pull requests

2 participants