Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Search title is no longer required, falls back to headline if blank #404

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Search title is no longer required, falls back to headline if blank #404

wants to merge 1 commit into from

Conversation

jacqui
Copy link
Contributor

@jacqui jacqui commented Jan 28, 2022 •
edited
Loading

Closes #396

  • removed "(required)" label from "search title" in form
  • updated form validation, blank search title no longer invalidates form
  • if no search title given, set to headline value

Related news-catalyst/next-tinynewsdemo#1068

To test:

  • use version 117 in script editor; test case already created for the Test Doc for Article Features
  • blank out the search title field
  • change the headline (optional)
  • preview or publish the article
  • note the form submission is allowed (validates) and the search title is now set to the headline value

@jacqui jacqui mentioned this pull request Jan 28, 2022
Closed
@jacqui jacqui requested a review from TylerFisher January 28, 2022 18:07
@jacqui jacqui self-assigned this Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TylerFisher TylerFisher Awaiting requested review from TylerFisher

Assignees

@jacqui jacqui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search title shouldn't be required anymore
1 participant
@jacqui