Improve License Clarity at Top Package Level #3792
Conversation
Signed-off-by: swastik <[email protected]>
Signed-off-by: swastik <[email protected]>
Signed-off-by: swastik <[email protected]>
There was a problem hiding this comment.
@swastkk you are regenerating all the tests with useless churn. This adds more things to review and is not ideal. Let's do things differently. You can delete your last commit and push regenerated test fixtures for only the tests which were failing.
...agedcode/data/alpine/apkbuild-problems/alpine14/community/ksshaskpass/APKBUILD-expected.json
Outdated
Show resolved
Hide resolved
swastkk
force-pushed
the
improve-license-clarity
branch
from
c5791ba
to
fa8fcfc
Compare
Signed-off-by: swastik <[email protected]>
swastkk
force-pushed
the
improve-license-clarity
branch
from
fa8fcfc
to
64957ec
Compare
|
@swastkk this is not correct atm:
This new plugin could be there in |
Signed-off-by: swastik <[email protected]>
There was a problem hiding this comment.
Does this make sure the license_clarity_score attribute is added only on using the --summary-package command line option? No. Look at your test regenerations, none of these tests have this option enabled, still have this attribute added.
You have to pass the package_summary option like we have the package_only CLI option here: https://github.com/nexB/scancode-toolkit/blob/develop/src/packagedcode/plugin_package.py#L203, then further pass it down to create_package_and_deps at https://github.com/nexB/scancode-toolkit/blob/develop/src/packagedcode/plugin_package.py#L263 and further to package.to_dict() at https://github.com/nexB/scancode-toolkit/blob/develop/src/packagedcode/plugin_package.py#L367 to actually be able to correctly set the attribute package_summary at https://github.com/swastkk/scancode-toolkit/blob/improve-license-clarity/src/packagedcode/models.py#L1544 you added thorugh this PR. Otherwise it's always set to one value.
…mary as Postscan Plugin Signed-off-by: swastik <[email protected]>
...an/copyright/debian-slim-2021-04-07/usr/share/doc/gcc-9-base/copyright-detailed.expected.yml
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,6 @@ | |||
| # Copyright Example Corp | |||
There was a problem hiding this comment.
Use real examples instead of synthetic ones.
There was a problem hiding this comment.
Can I use that change-case-5.4.4 example here as it has 4 packages inside it and can be more helpful while we have calculated the license_clarity_score since till now we just want to check if the plugin is working?
There was a problem hiding this comment.
I have added this test case, please have a look, otherwise we can remove this as well.
tests/summarycode/data/package_summary/basic-plugin-testing/expected.json
Outdated
Show resolved
Hide resolved
…inor changes Signed-off-by: swastik <[email protected]>
Signed-off-by: swastik <[email protected]>
Signed-off-by: swastik <[email protected]>
swastkk
force-pushed
the
improve-license-clarity
branch
from
eb60d58
to
9da7f6e
Compare
Fixes #3802
Tasks
Run tests locally to check for errors.