Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atlassian Provider not working but its in the docs for v5 #11613

Closed
tcarbs opened this issue Aug 16, 2024 · 6 comments · Fixed by #11987
Closed

Atlassian Provider not working but its in the docs for v5 #11613

tcarbs opened this issue Aug 16, 2024 · 6 comments · Fixed by #11987
Labels
docs Relates to documentation good first issue Good issue to take for first time contributors providers

Comments

@tcarbs
Copy link

tcarbs commented Aug 16, 2024

What is the improvement or update you wish to see?

I would like to see Atlassian implemented in v5. I see it is in v4, maybe you guys just haven't gotten around to it. All good, but remove it as an option from your v5 docs when you search for OAuth providers.

Is there any context that might help us understand?

These are the docs for v5.
https://authjs.dev/getting-started/authentication/oauth

You can search for Atlassian but it is not in the v5 packages.
https://github.com/nextauthjs/next-auth/tree/main/packages/core/src/providers

Does the docs page already exist? Please link to it.

https://authjs.dev/getting-started/authentication/oauth

@tcarbs tcarbs added docs Relates to documentation triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. labels Aug 16, 2024
@tcarbs
Copy link
Author

tcarbs commented Aug 16, 2024

found the actual link that is empty.

https://authjs.dev/getting-started/providers/atlassian

@arwanfiles

This comment has been minimized.

@quinnsprouse
Copy link

Running into the same issue...

@balazsorban44
Copy link
Member

balazsorban44 commented Sep 25, 2024

I dropped the code in cb1a260

but quite frankly I don't remember why. From my description, I assessed it was somehow relying on OAuth 1.0, which is not supported anymore.

Im fine if we re-add it. Here is the documentation https://developer.atlassian.com/cloud/jira/software/oauth-2-3lo-apps/

@balazsorban44 balazsorban44 added providers good first issue Good issue to take for first time contributors and removed triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. labels Sep 25, 2024
Copy link

This issue was marked with the good first issue label by a maintainer.

This means that it is a good candidate for someone interested in contributing to the project, but does not know where to start.

Have a look at the Contributing Guide first.

This will help you set up your development environment to get started. When you are ready, open a PR, and link back to this issue in the form of adding Fixes #1234 to the PR description, where 1234 is the issue number. This will auto-close the issue when the PR gets merged, making it easier for us to keep track of what has been fixed.

Please make sure that - if applicable - you add tests for the changes you make.

If you have any questions, feel free to ask in the comments below or the PR. Generally, you don't need to @mention anyone directly, as we will get notified anyway and will respond as soon as we can)

Note

There is no need to ask for permission "can I work on this?" Please, go ahead if there is no linked PR 🙂

@DevRish
Copy link
Contributor

DevRish commented Oct 7, 2024

@balazsorban44 Thanks for providing the latest docs! I have made the necessary modifications for oauth2.0 and brought back the atlassian provider. Please review the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Relates to documentation good first issue Good issue to take for first time contributors providers
Projects
None yet
5 participants