Skip to content

Commit d11c189

Browse files
Fix eslint errors
Signed-off-by: Raimund Schlüßler <[email protected]>
1 parent 1c59480 commit d11c189

File tree

6 files changed

+11
-7
lines changed

6 files changed

+11
-7
lines changed

src/components/NcBreadcrumb/NcBreadcrumb.vue

+1
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,7 @@ export default {
191191
}
192192
/**
193193
* Event emitted when something is dropped on the breadcrumb.
194+
*
194195
* @param {Event} event The DOM drop event
195196
* @param {(string|object)} to The `to` prop or, if not set, the `href` prop
196197
*/

src/components/NcGuestContent/NcGuestContent.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export default {
5555
mounted() {
5656
document.getElementById('content').classList.add('nc-guest-content')
5757
},
58-
destroyed() {
58+
unmounted() {
5959
document.getElementById('content').classList.remove('nc-guest-content')
6060
},
6161
}

src/components/NcHeaderMenu/NcHeaderMenu.vue

+3-1
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,9 @@ export default {
142142

143143
emits: [
144144
'close',
145+
'closed',
145146
'open',
147+
'opened',
146148
'update:open',
147149
'cancel',
148150
],
@@ -173,7 +175,7 @@ export default {
173175
mounted() {
174176
document.addEventListener('keydown', this.onKeyDown)
175177
},
176-
beforeDestroy() {
178+
beforeUnmount() {
177179
document.removeEventListener('keydown', this.onKeyDown)
178180
},
179181

src/components/NcPopover/NcPopover.vue

+1
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ export default {
130130
setReturnFocus: {
131131
required: false,
132132
type: Object,
133+
default: false,
133134
},
134135
},
135136

src/components/NcSelect/NcSelect.vue

+2-2
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,6 @@ export default {
472472
'select--no-wrap': noWrap,
473473
}"
474474
v-bind="propsToForward"
475-
v-on="$listeners"
476475
@search="searchString => search = searchString">
477476
<template #open-indicator="{ attributes }">
478477
<ChevronDown v-bind="attributes"
@@ -504,7 +503,7 @@ export default {
504503
<template #no-options>
505504
{{ t('No results') }}
506505
</template>
507-
<template v-for="(_, name) in $scopedSlots" #[name]="data">
506+
<template v-for="(_, name) in $slots" #[name]="data">
508507
<!-- @slot Any combination of slots from https://vue-select.org/api/slots.html -->
509508
<slot :name="name" v-bind="data" />
510509
</template>
@@ -769,6 +768,7 @@ export default {
769768

770769
const propsToForward = {
771770
...initialPropsToForward,
771+
...this.$attrs,
772772
label: this.localLabel,
773773
}
774774

src/components/NcSelectTags/NcSelectTags.vue

+3-3
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ export default {
137137
:value="localValue"
138138
@search="searchString => search = searchString"
139139
@input="handleInput"
140-
v-on="{ ...$listeners, input: () => {} }">
140+
v-on="{ input: () => {} }">
141141
<!-- Do not forward input event listener to NcSelect as we emit custom input events programmatically -->
142142
<template #option="option">
143143
<NcEllipsisedOption :name="getOptionLabel(option)"
@@ -147,7 +147,7 @@ export default {
147147
<NcEllipsisedOption :name="getOptionLabel(selectedOption)"
148148
:search="search" />
149149
</template>
150-
<template v-for="(_, name) in $scopedSlots" #[name]="data">
150+
<template v-for="(_, name) in $slots" #[name]="data">
151151
<!-- @slot Any combination of slots from https://vue-select.org/api/slots.html -->
152152
<slot :name="name" v-bind="data" />
153153
</template>
@@ -286,7 +286,7 @@ export default {
286286
...propsToForward
287287
} = this.$props
288288

289-
return propsToForward
289+
return { propsToForward, ...this.$attrs }
290290
},
291291
},
292292

0 commit comments

Comments
 (0)