fix(NcRichText): async import remark-gfm library #6259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
added
3. to review
ShGKme
reviewed
Nov 22, 2024
There was a problem hiding this comment.
I'm not sure this is a good idea with remark-gfm.
If the connection is slow - it first renders the raw text value, and then it flashes to rendered Markdown.
Unlike code => code with highlights update, this is a huge visible change. Imagine a message with headings and lists, that is first a plain text and then formatted.
I'm not sure we need a dynamic module here. But if we do it, we should render content ONLY when remark-gfm is loaded, and render nothing during loading.
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
fix/6246/async-load-remark-gfm
branch
from
cc74645
to
49ce673
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
remark-gfmcould be async loaded to reduce initial size #6246remark-gfmis 39.5 kB in dev build, which is 30% of rehype-highlight library size (111kB which we're also importing async)rehype-highlightwon't be imported for code blocks without language provided/recognised🖼️ Screenshots
No visual changes
🏁 Checklist
nextrequested with a Vue 3 upgradeSigned-off-by: Maksim Sukharev [email protected]