Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NcEmojiPicker] Focus is lost on close #6341

Open
ShGKme opened this issue Jan 2, 2025 · 1 comment · May be fixed by #6342
Open

[NcEmojiPicker] Focus is lost on close #6341

ShGKme opened this issue Jan 2, 2025 · 1 comment · May be fixed by #6342
Assignees
@ShGKme
Labels
2. developing Work in progress accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: emoji picker Related to the emoji picker component

Comments

@ShGKme
Copy link
Contributor

ShGKme commented Jan 2, 2025

Closing the emoji picker should move the focus to the trigger button. Instead, it moves the focus to the search input inside the picker and then to the body.
@ShGKme ShGKme added bug Something isn't working 1. to develop Accepted and waiting to be taken care of accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: emoji picker Related to the emoji picker component labels Jan 2, 2025
@ShGKme
Copy link
Contributor Author

ShGKme commented Jan 2, 2025

This happens because the Search focus inside NcEmojiPicker happens before NcPopover activates the focus trap.

@ShGKme ShGKme added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Jan 2, 2025
@ShGKme ShGKme self-assigned this Jan 2, 2025
@ShGKme ShGKme linked a pull request Jan 2, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShGKme ShGKme

Labels
2. developing Work in progress accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: emoji picker Related to the emoji picker component
Projects
None yet
Milestone
No milestone
1 participant
@ShGKme