Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digests recipient selection #1768

Closed
raboof opened this issue Aug 31, 2024 · 1 comment
Closed

Digests recipient selection #1768

raboof opened this issue Aug 31, 2024 · 1 comment

Comments

@raboof
Copy link

raboof commented Aug 31, 2024

lib/DigestSender.php is fetching users via $this->config->getUsersForUserValue('activity', 'notify_setting_activity_digest', '1');. This does not exclude disabled users on either side. Is this an oversight, or is the assumption that notify_setting_activity_digest should be disabled for disabled users?

(this is with Nextcloud 27.1.4, Activity 2.19.0)

@raboof raboof changed the title Digests are sent even for disabled users Digests recipient selection Sep 4, 2024
@joshtrichards
Copy link
Member

I was about to respond that I see a check a bit farther down the code path that does check for disabled users:

if (!$userObject->isEnabled()) {
// User is disabled so do not send the email but update last sent since after enabling avoid flooding
$this->updateLastSentForUser($userObject, $now);
continue;

But just noticed that someone else (Hi @yemkareems!) happens to have fixed this (via #1803) shortly after your original report so that's where that code comes from. :)

So, yes, good catch and I think we're good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants