fix code analytics, simplify

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

Author: alperozturk96

app/src/main/java/com/nextcloud/client/jobs/BackgroundJobManager.kt

@@ -139,11 +139,7 @@ interface BackgroundJobManager {
     fun startNotificationJob(subject: String, signature: String)
     fun startAccountRemovalJob(accountName: String, remoteWipe: Boolean)
     fun startFilesUploadJob(user: User, uploadIds: LongArray, showSameFileAlreadyExistsNotification: Boolean)
-    fun startAlbumFilesUploadJob(
-        user: User,
-        uploadIds: LongArray,
-        albumName: String,
-    )
+    fun startAlbumFilesUploadJob(user: User, uploadIds: LongArray, albumName: String)
     fun getFileUploads(user: User): LiveData<List<JobInfo>>
     fun cancelFilesUploadJob(user: User)
     fun isStartFileUploadJobScheduled(accountName: String): Boolean

app/src/main/java/com/nextcloud/client/jobs/BackgroundJobManagerImpl.kt

@@ -717,11 +717,7 @@ internal class BackgroundJobManagerImpl(
      *                  within the worker.
      * @param albumName Album on which selected files should be copy after upload
      */
-    override fun startAlbumFilesUploadJob(
-        user: User,
-        uploadIds: LongArray,
-        albumName: String,
-    ) {
+    override fun startAlbumFilesUploadJob(user: User, uploadIds: LongArray, albumName: String) {
         defaultDispatcherScope.launch {
             val batchSize = FileUploadHelper.MAX_FILE_COUNT
             val batches = uploadIds.toList().chunked(batchSize)

app/src/main/java/com/nextcloud/client/jobs/notification/WorkerNotificationManager.kt

@@ -90,16 +90,14 @@ open class WorkerNotificationManager(
             ForegroundServiceType.DataSync
         )
 
-    fun createSilentNotification(title: String, iconId: Int): Notification {
-        return notificationBuilder
-            .setContentTitle(title)
-            .setSmallIcon(iconId)
-            .setOngoing(true)
-            .setSound(null)
-            .setVibrate(null)
-            .setOnlyAlertOnce(true)
-            .setPriority(NotificationCompat.PRIORITY_LOW)
-            .setSilent(true)
-            .build()
-    }
+    fun createSilentNotification(title: String, iconId: Int): Notification = notificationBuilder
+        .setContentTitle(title)
+        .setSmallIcon(iconId)
+        .setOngoing(true)
+        .setSound(null)
+        .setVibrate(null)
+        .setOnlyAlertOnce(true)
+        .setPriority(NotificationCompat.PRIORITY_LOW)
+        .setSilent(true)
+        .build()
 }

app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadHelper.kt

@@ -233,16 +233,21 @@ class FileUploadHelper {
     @JvmOverloads
     fun uploadNewFiles(data: OCUploadLocalPathData, showSameFileAlreadyExistsNotification: Boolean = true) {
         val uploads = getUploadsFromLocalPaths(data)
-        backgroundJobManager.startFilesUploadJob(data.user, uploads.getUploadIds(), showSameFileAlreadyExistsNotification)
+        backgroundJobManager.startFilesUploadJob(
+            data.user,
+            uploads.getUploadIds(),
+            showSameFileAlreadyExistsNotification
+        )
     }
 
-    private fun getUploadsFromLocalPaths(data: OCUploadLocalPathData): List<OCUpload> {
-        return data.localPaths.mapIndexed { index, localPath ->
-            val result = data.toOCUpload(localPath, index)
-            val id = uploadsStorageManager.uploadDao.insertOrReplace(result.toUploadEntity())
-            result.uploadId = id
-            result
-        }
+    private fun getUploadsFromLocalPaths(data: OCUploadLocalPathData): List<OCUpload> = data.localPaths.mapIndexed {
+            index,
+            localPath
+        ->
+        val result = data.toOCUpload(localPath, index)
+        val id = uploadsStorageManager.uploadDao.insertOrReplace(result.toUploadEntity())
+        result.uploadId = id
+        result
     }
 
     @Suppress("LongParameterList")

app/src/main/java/com/nextcloud/model/OCUploadLocalPathData.kt

@@ -23,15 +23,11 @@ data class OCUploadLocalPathData(
     val creationType: Int,
     val requiresWifi: Boolean,
     val requiresCharging: Boolean,
-    val collisionPolicy: NameCollisionPolicy,
+    val collisionPolicy: NameCollisionPolicy
 ) {
     companion object {
-        fun forDocument(
-            user: User,
-            localPaths: Array<String>,
-            remotePaths: Array<String>
-        ): OCUploadLocalPathData {
-            return OCUploadLocalPathData(
+        fun forDocument(user: User, localPaths: Array<String>, remotePaths: Array<String>): OCUploadLocalPathData =
+            OCUploadLocalPathData(
                 user,
                 localPaths,
                 remotePaths,
@@ -42,26 +38,23 @@ data class OCUploadLocalPathData(
                 requiresCharging = false,
                 NameCollisionPolicy.ASK_USER
             )
-        }
 
         fun forAlbum(
             user: User,
             localPaths: Array<String>,
             remotePaths: Array<String>,
             localBehavior: Int
-        ): OCUploadLocalPathData {
-            return OCUploadLocalPathData(
-                user,
-                localPaths,
-                remotePaths,
-                localBehavior,
-                createRemoteFolder = true,
-                UploadFileOperation.CREATED_BY_USER,
-                requiresWifi = false,
-                requiresCharging = false,
-                NameCollisionPolicy.RENAME
-            )
-        }
+        ): OCUploadLocalPathData = OCUploadLocalPathData(
+            user,
+            localPaths,
+            remotePaths,
+            localBehavior,
+            createRemoteFolder = true,
+            UploadFileOperation.CREATED_BY_USER,
+            requiresWifi = false,
+            requiresCharging = false,
+            NameCollisionPolicy.RENAME
+        )
 
         @JvmOverloads
         fun forFile(
@@ -70,23 +63,21 @@ data class OCUploadLocalPathData(
             remotePaths: Array<String>,
             localBehavior: Int,
             createRemoteFolder: Boolean = false
-        ): OCUploadLocalPathData {
-            return OCUploadLocalPathData(
-                user,
-                localPaths,
-                remotePaths,
-                localBehavior,
-                createRemoteFolder = createRemoteFolder,
-                UploadFileOperation.CREATED_BY_USER,
-                requiresWifi = false,
-                requiresCharging = false,
-                NameCollisionPolicy.ASK_USER
-            )
-        }
+        ): OCUploadLocalPathData = OCUploadLocalPathData(
+            user,
+            localPaths,
+            remotePaths,
+            localBehavior,
+            createRemoteFolder = createRemoteFolder,
+            UploadFileOperation.CREATED_BY_USER,
+            requiresWifi = false,
+            requiresCharging = false,
+            NameCollisionPolicy.ASK_USER
+        )
     }
 
-    fun toOCUpload(localPath: String, index: Int): OCUpload {
-        return OCUpload(localPath, remotePaths[index], user.accountName).apply {
+    fun toOCUpload(localPath: String, index: Int): OCUpload =
+        OCUpload(localPath, remotePaths[index], user.accountName).apply {
             nameCollisionPolicy = collisionPolicy
             isUseWifiOnly = requiresWifi
             isWhileChargingOnly = requiresCharging
@@ -95,7 +86,6 @@ data class OCUploadLocalPathData(
             isCreateRemoteFolder = createRemoteFolder
             localAction = localBehavior
         }
-    }
 
     override fun equals(other: Any?): Boolean {
         if (this === other) return true

app/src/main/java/com/nextcloud/ui/fileactions/FileActionsBottomSheet.kt

@@ -152,7 +152,8 @@ class FileActionsBottomSheet :
                 binding.thumbnailLayout.thumbnailShimmer,
                 syncedFolderProvider.preferences,
                 viewThemeUtils,
-                syncedFolderProvider
+                syncedFolderProvider,
+                false
             )
         }
     }

app/src/main/java/com/nextcloud/ui/trashbinFileActions/TrashbinFileActionsBottomSheet.kt

@@ -128,7 +128,8 @@ class TrashbinFileActionsBottomSheet :
                 binding.thumbnailLayout.thumbnailShimmer,
                 syncedFolderProvider.preferences,
                 viewThemeUtils,
-                syncedFolderProvider
+                syncedFolderProvider,
+                false
             )
         }
     }

app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt

@@ -2941,6 +2941,7 @@ class FileDisplayActivity :
         initFile()
     }
 
+    @Suppress("LongMethod")
     private fun initFile() {
         val userOpt = user
         if (userOpt.isEmpty) {

app/src/main/java/com/owncloud/android/ui/adapter/LinkShareViewHolder.kt

@@ -98,6 +98,7 @@ internal class LinkShareViewHolder(itemView: View) : RecyclerView.ViewHolder(ite
         }
     }
 
+    @Suppress("ReturnCount")
     private fun setSubline(binding: FileDetailsShareLinkShareItemBinding?, context: Context?, publicShare: OCShare) {
         if (binding == null || context == null) {
             return

app/src/main/java/com/owncloud/android/ui/adapter/OCFileListDelegate.kt

@@ -198,7 +198,8 @@ class OCFileListDelegate(
             shimmerThumbnail,
             preferences,
             viewThemeUtils,
-            syncFolderProvider
+            syncFolderProvider,
+            false
         )
     }