fix: replace custom getters/setters with magic methods for session's isRemembered and isSummaryUpToDate

Signed-off-by: Julien Veyssier <[email protected]>

Author: julien-nc

lib/Controller/ChattyLLMController.php

@@ -219,7 +219,7 @@ public function updateChatSession(int $sessionId, ?string $title = null, ?bool $
 				$session->setTitle($title);
 			}
 			if ($is_remembered !== null) {
-				$session->setIsRemembered($is_remembered);
+				$session->setIsRemembered($is_remembered ? 1 : 0);
 				// schedule summarizer jobs for this chat user
 				if ($is_remembered) {
 					$this->sessionSummaryService->scheduleJobsForUser($this->userId);
@@ -824,7 +824,7 @@ public function checkSession(int $sessionId): JSONResponse {
 			'messageTaskId' => null,
 			'titleTaskId' => null,
 			'sessionTitle' => $session->getTitle(),
-			'is_remembered' => $session->getIsRemembered(),
+			'is_remembered' => $session->getIsRemembered() !== 0,
 			'sessionAgencyPendingActions' => $p,
 		];
 		if (!empty($messageTasks)) {

lib/Db/ChattyLLM/Session.php

@@ -25,6 +25,10 @@
  * @method \void setAgencyConversationToken(?string $agencyConversationToken)
  * @method \string|null getAgencyPendingActions()
  * @method \void setAgencyPendingActions(?string $agencyPendingActions)
+ * @method \int getIsRemembered()
+ * @method \void setIsRemembered(int $isRemembered)
+ * @method \int getIsSummaryUpToDate()
+ * @method \void setIsSummaryUpToDate(int $isSummaryUpToDate)
  */
 class Session extends Entity implements \JsonSerializable {
 	/** @var string */
@@ -100,24 +104,8 @@ public function jsonSerialize() {
 			'agency_conversation_token' => $this->getAgencyConversationToken(),
 			'agency_pending_actions' => $this->getAgencyPendingActions(),
 			'summary' => $this->getSummary(),
-			'is_summary_up_to_date' => $this->getIsSummaryUpToDate(),
-			'is_remembered' => $this->getIsRemembered(),
+			'is_summary_up_to_date' => $this->getIsSummaryUpToDate() !== 0,
+			'is_remembered' => $this->getIsRemembered() !== 0,
 		];
 	}
-
-	public function setIsSummaryUpToDate(bool $value): void {
-		$this->setter('isSummaryUpToDate', [$value ? 1 : 0]);
-	}
-
-	public function setIsRemembered(bool $value): void {
-		$this->setter('isRemembered', [$value ? 1 : 0]);
-	}
-
-	public function getIsSummaryUpToDate(): bool {
-		return $this->getter('isSummaryUpToDate') === 1;
-	}
-
-	public function getIsRemembered(): bool {
-		return $this->getter('isRemembered') === 1;
-	}
 }

lib/Db/ChattyLLM/SessionMapper.php

@@ -182,7 +182,7 @@ public function deleteSession(string $userId, int $sessionId) {
 
 	public function updateSessionIsRemembered(?string $userId, int $sessionId, bool $is_remembered) {
 		$session = $this->getUserSession($userId, $sessionId);
-		$session->setIsRemembered($is_remembered);
+		$session->setIsRemembered($is_remembered ? 1 : 0);
 		$this->update($session);
 	}
 }

lib/Listener/ChattyLLMTaskListener.php

@@ -125,7 +125,7 @@ public function handle(Event $event): void {
 				$session->setAgencyPendingActions($pendingActions);
 			}
 			// Set flag that the conversation summary needs to be regenerated
-			$session->setIsSummaryUpToDate(false);
+			$session->setIsSummaryUpToDate(0);
 
 			$this->sessionMapper->update($session);
 		}

lib/Service/SessionSummaryService.php

@@ -57,7 +57,7 @@ private function generateSummaries(array $sessions): void {
 				], 'assistant', $session->getUserId());
 				$output = $this->taskProcessingService->runTaskProcessingTask($task);
 				$session->setSummary($output['output']);
-				$session->setIsSummaryUpToDate(true);
+				$session->setIsSummaryUpToDate(1);
 				$this->sessionMapper->update($session);
 			} catch (\Throwable $e) {
 				$this->logger->warning('Failed to generate summary for chat session ' . $session->getId(), ['exception' => $e]);