chore: Mark IUserConfig entries as lazy#173
Merged
marcelklehr merged 3 commits intomainfrom Feb 5, 2026
Merged
Conversation
where needed Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
julien-nc
approved these changes
Feb 5, 2026
| * @param array $options | ||
| */ | ||
| public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options) { | ||
| foreach ($this->userConfig->getUserIds(Application::APP_ID) as $userId) { |
Member
There was a problem hiding this comment.
Oh nice, i didn't know about userConfig->getUserIds.
| } | ||
| } | ||
|
|
||
| // store oauth_instance_url as non-lazy |
Member
There was a problem hiding this comment.
Maybe do the same for the navigation_enabled and url user keys? Check if it's there lazy and store it as non lazy.
I know those values are not supposed to have been stored previously as lazy but why not?
Member
Author
There was a problem hiding this comment.
They are queried on each request, that's why I didn't make them lazy.
Member
There was a problem hiding this comment.
Sorry for the confusion. I'm not saying why not making them lazy? but rather why not adding the extra step to read and store them non-lazy if they are stored lazy?
Member
Author
There was a problem hiding this comment.
But they're not stored as lazy? :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
where needed