Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php8.2: Handling HTML entities via mbstring is deprecated at /news/lib/Fetcher/FeedFetcher.php#319 #2609

Open
2 tasks done
uncovery opened this issue Mar 9, 2024 · 4 comments
Labels

Comments

@uncovery
Copy link

uncovery commented Mar 9, 2024

IMPORTANT

Read and tick the following checkbox after you have created the issue or place an x inside the brackets ;)

  • I have read the CONTRIBUTING.md and followed the provided tips
  • [x ] I accept that the issue will be closed without comment if I do not check here
  • I accept that the issue will be closed without comment if I do not fill out all items in the issue template.

Explain the Problem

What problem did you encounter?

Steps to Reproduce

look at the logfile

System Information

  • News app version: 25.0.0.aplha4
  • Nextcloud version: 28.0.3
  • Cron type: system cron
  • PHP version: 8.2
  • OS and version: Almalinux 9
Contents of nextcloud/data/nextcloud.log
{"reqId":"pPJ4srmH83A0Yr3nDsmW","level":0,"time":"2024-03-08T16:20:13+00:00","remoteAddr":"","user":"--","app":"PHP","method":"","url":"--","message":"mb_convert_encoding(): Handling HTML entities via mbstring is deprecated; use htmlspecialchars, htmlentities, or mb_encode_numericentity/mb_decode_numericentity instead at /var/www/nextcloud/public_html/apps/news/lib/Fetcher/FeedFetcher.php#319","userAgent":"--","version":"28.0.3.2","data":{"app":"PHP"}}
@uncovery uncovery added the bug label Mar 9, 2024
@Grotax
Copy link
Member

Grotax commented May 18, 2024

Hi we can't fix this at the moment.
We would need to upgrade feed-io and drop support for older php versions.

@SMillerDev
Copy link
Contributor

@Grotax we did this now right?

@Grotax
Copy link
Member

Grotax commented Dec 1, 2024

I don't think so feed-io was not upgraded in a while, even downgraded one time since it brought a regression.

I think feed-io 6 might fix this but it requires changes to how feed-io is initialized since it uses this pluggable http client concept.

But I'm not a 100% in this topic.

Upgrade to feed-io 6 is definitely a topic to be done at some point though.

@IgorA100
Copy link
Contributor

Upgrade to feed-io 6 is definitely a topic to be done at some point though.

I once tested feed-io 6
But I failed use User-Agent for HttplugClient alexdebril/feed-io#421
Maybe I did something wrong. I did not continue testing feed-io 6
Some RSS feeds require the correct User-Agent.
When switching to feed-io 6, you should pay attention to this. And you may have to create a PR for feed-io 6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants