[25.1.1] "Enable full text" does not work

[IgorA100]

IMPORTANT

Read and tick the following checkbox after you have created the issue or place an x inside the brackets ;)

• [V ] I have read the CONTRIBUTING.md and followed the provided tips
• [V ] I accept that the issue will be closed without comment if I do not check here
• [V ] I accept that the issue will be closed without comment if I do not fill out all items in the issue template.

Explain the Problem

Switching to display full text does not work.
Only short text is always displayed.
Is it just me who has a problem or is this functionality not yet implemented in version 25? There were no problems in 24.

System Information

• News app version: 25.1.1
• Nextcloud version: [Nextcloud Hub 9] (30.0.4)
• Cron type: system cron
• PHP version: 8.3

[Grotax]

Just to make sure you understand what that function does.

To enable full text means that news will attempt to open the link to the page of the article and to parse the website for the main content.
The text fetched there will replace the text that was provided by the feed.

It does not have an impact on the UI and might also not always work since websites and feeds are very different.

Does that answer your question?

[IgorA100]

Does that answer your question?

I haven't analyzed how it works in depth.
Thanks for the explanation!
I have one site that had no problems in version 24. But the site uses relative links. I created a PR in https://github.com/alexdebril/feed-io/pulls for the correct operation of relative links. And it really works correctly.
But now I see errors in the log:

And apparently it is because of these errors that the full text is not displayed.
If the full text is really not displayed because of relative links, then I will examine the code to make a PR here or on https://github.com/alexdebril/feed-io

[IgorA100]

OOohhh...
I made a slight mistake.
The problem is not with displaying the full text, but with switching the viewing mode.
Sorry, but I will ask the question here, so as not to create a new Issue
Earlier in version 24, there was a checkbox in the settings called "Compact mode". I disabled it and the news was displayed in the form I needed.
Now there is a selector "Display mode". I provided screenshots with the "Default" mode enabled.
But I want the news in the list to be displayed as it was in version 24 with "Compact mode" disabled:

I tried switching to "Screenreader" mode, but it turns out something terrible...

[wofferl]

The "screenreader" mode is a special mode for people who rely on text2speech software.

There is currently no mode, like the old non-compact mode, which shows whole articles in the list, implemented.

[IgorA100]

There is currently no mode, like the old non-compact mode, which shows whole articles in the list, implemented.

Ok, I understand. What's the difficulty in implementing it? Maybe I can help somehow?

[wofferl]

There is currently no mode, like the old non-compact mode, which shows whole articles in the list, implemented.

Ok, I understand. What's the difficulty in implementing it? Maybe I can help somehow?

The old implementation only added new items to the end while scrolling and therefore did not have to worry about calculating the position. However, this was at the cost of performance the longer a session lasted.

The current implementation only keeps the visible items in the scroll, and therefore uses static item heights for the calculation.

This needs to be rewritten to be able to handle dynamic item heights, but this would probably also lead to performance losses.

[Grotax]

Does that answer your question?

I haven't analyzed how it works in depth. Thanks for the explanation! I have one site that had no problems in version 24. But the site uses relative links. I created a PR in https://github.com/alexdebril/feed-io/pulls for the correct operation of relative links. And it really works correctly. But now I see errors in the log:

And apparently it is because of these errors that the full text is not displayed. If the full text is really not displayed because of relative links, then I will examine the code to make a PR here or on https://github.com/alexdebril/feed-io

Now that you mention it I remember. When we merged the version that included your PR for relative links they started working but in return it broke other links so feed-io was downgraded. Maybe you can take another look at it and make sure that all kinds of links are treated correctly.

#2497

[IgorA100]

Maybe you can take another look at it and make sure that all kinds of links are treated correctly.

Very interesting.
I will definitely check it out.
I didn't notice the message from December 19, 2023. :(

[IgorA100]

feed-io was downgraded.

I created a PR fixing the problem with Atom feed https://github.com/alexdebril/feed-io/pull/431/files
I will test it for another 1-2 days.
If someone can test my PR - I will be grateful!