fix(openapi): Don't mark unknown default values as required

Signed-off-by: Joas Schilling <[email protected]>

Author: nickvergessen

src/ControllerMethod.php

@@ -545,6 +545,8 @@ public static function parse(string $context,
 					$type->defaultValue = Helpers::exprToValue($context, $methodParameter->default);
 					$type->hasDefaultValue = true;
 				} catch (UnsupportedExprException $e) {
+					$type->hasDefaultValue = true;
+					$type->hasUnknownDefaultValue = true;
 					Logger::debug($context, $e);
 				}
 			}

src/OpenApiType.php

@@ -42,6 +42,7 @@ public function __construct(
 		public ?string $format = null,
 		public bool $nullable = false,
 		public bool $hasDefaultValue = false,
+		public bool $hasUnknownDefaultValue = false,
 		public bool $deprecated = false,
 		public mixed $defaultValue = null,
 		public ?OpenApiType $items = null,
@@ -92,7 +93,7 @@ public function toArray(bool $isParameter = false): array|stdClass {
 		if ($this->deprecated) {
 			$values['deprecated'] = true;
 		}
-		if ($this->hasDefaultValue) {
+		if ($this->hasDefaultValue && !$this->hasUnknownDefaultValue) {
 			$values['default'] = $this->type === 'object' && is_array($this->defaultValue) && count($this->defaultValue) === 0 ? new stdClass() : $this->defaultValue;
 		}
 		if ($this->enum !== null) {

tests/openapi-administration.json

@@ -9276,14 +9276,11 @@
                     }
                 ],
                 "requestBody": {
-                    "required": true,
+                    "required": false,
                     "content": {
                         "application/json": {
                             "schema": {
                                 "type": "object",
-                                "required": [
-                                    "option2"
-                                ],
                                 "properties": {
                                     "option1": {
                                         "type": "integer",

tests/openapi-full.json

@@ -9476,14 +9476,11 @@
                     }
                 ],
                 "requestBody": {
-                    "required": true,
+                    "required": false,
                     "content": {
                         "application/json": {
                             "schema": {
                                 "type": "object",
-                                "required": [
-                                    "option2"
-                                ],
                                 "properties": {
                                     "option1": {
                                         "type": "integer",