feat(OpenApiType): Warn about non-required nullable properties

provokateurin · provokateurin · commit 7c198c88884b · 2024-12-17T14:13:26.000+01:00
Signed-off-by: provokateurin &lt;kate@provokateurin.de&gt;
diff --git a/src/OpenApiType.php b/src/OpenApiType.php
@@ -210,6 +210,8 @@ public static function resolve(string $context, array $definitions, ParamTagValu
 				$properties[$name] = $type;
 				if (!$item->optional) {
 					$required[] = $name;
+				} elseif ($type->nullable) {
+					Logger::warning($context, 'Property "' . $name . '" is both nullable and not required. Please consider only using one of these at once.');
 				}
 			}
 			return new OpenApiType(

Original file line number	Diff line number	Diff line change
`@@ -210,6 +210,8 @@ public static function resolve(string $context, array $definitions, ParamTagValu`
`210`	`210`	`$properties[$name] = $type;`
`211`	`211`	`if (!$item->optional) {`
`212`	`212`	`$required[] = $name;`
	`213`	`+ } elseif ($type->nullable) {`
	`214`	`+ Logger::warning($context, 'Property "' . $name . '" is both nullable and not required. Please consider only using one of these at once.');`
`213`	`215`	`}`
`214`	`216`	`}`
`215`	`217`	`return new OpenApiType(`