Skip to content

Commit 823a8b6

Browse files
committed
feat(generate-spec): Disallow unused route requirements
Signed-off-by: provokateurin <[email protected]>
1 parent 63bbc54 commit 823a8b6

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

generate-spec.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -587,6 +587,11 @@
587587
preg_match_all('/{[^}]*}/', $route->url, $urlParameters);
588588
$urlParameters = array_map(fn (string $name): string => substr($name, 1, -1), $urlParameters[0]);
589589

590+
$unusedRequirements = array_diff(array_keys($route->requirements), $urlParameters);
591+
if ($unusedRequirements !== []) {
592+
Logger::error($route->name, 'Unused requirements: ' . implode(',', $unusedRequirements));
593+
}
594+
590595
foreach ($urlParameters as $urlParameter) {
591596
$matchingParameters = array_filter($route->controllerMethod->parameters, fn (ControllerMethodParameter $param): bool => $param->name == $urlParameter);
592597
$requirement = $route->requirements[$urlParameter] ?? null;

0 commit comments

Comments
 (0)