refactor: Use strict boolean comparisons

Signed-off-by: provokateurin <[email protected]>

Author: provokateurin

generate-spec.php

@@ -465,8 +465,8 @@
 			Logger::panic($routeName, 'Route is marked as ignore but also has other scopes');
 		}
 
-		if (empty($scopes)) {
-			if (!empty($controllerScopes)) {
+		if ($scopes === []) {
+			if ($controllerScopes !== []) {
 				$scopes = $controllerScopes;
 			} elseif ($isExApp) {
 				$scopes = ['ex_app'];
@@ -949,11 +949,11 @@
 		foreach ($paths as $url => $urlRoutes) {
 			foreach ($urlRoutes as $httpMethod => $routeData) {
 				foreach ($routeData['responses'] as $statusCode => $responseData) {
-					if (!empty($responseData['content'])) {
+					if (isset($responseData['content']) && $responseData['content'] !== []) {
 						$usedSchemas[] = Helpers::collectUsedRefs($responseData['content']);
 					}
 				}
-				if (!empty($routeData['requestBody']['content'])) {
+				if (isset($routeData['requestBody']['content']) && $routeData['requestBody']['content'] !== []) {
 					$usedSchemas[] = Helpers::collectUsedRefs($routeData['requestBody']['content']);
 				}
 			}

rector.php

@@ -10,4 +10,5 @@
 	->withPhpSets()
 	->withPreparedSets(
 		typeDeclarations: true,
+		strictBooleans: true,
 	);

src/Helpers.php

@@ -252,16 +252,16 @@ public static function getOpenAPIAttributeTagsByScope(ClassMethod|Class_|Node $n
 							if ($item?->value instanceof String_) {
 								$tag = $item->value->value;
 								$pattern = '/^[0-9a-zA-Z_-]+$/';
-								if (!preg_match($pattern, $tag)) {
+								if (in_array(preg_match($pattern, $tag), [0, false], true)) {
 									Logger::error($routeName, 'Tag "' . $tag . '" has to match pattern "' . $pattern . '"');
 								}
 								$foundTags[] = $tag;
 							}
 						}
 					}
 
-					if (!empty($foundTags)) {
-						$tags[$foundScopeName ?: $defaultScope] = $foundTags;
+					if ($foundTags !== []) {
+						$tags[$foundScopeName !== null && $foundScopeName !== '' && $foundScopeName !== '0' ? $foundScopeName : $defaultScope] = $foundTags;
 					}
 				}
 			}

src/OpenApiType.php

@@ -347,7 +347,7 @@ enum: $values,
 				return $item->type;
 			}, $items);
 
-			if (!empty(array_filter($itemTypes, static fn (?string $type): bool => $type === null)) || count($itemTypes) !== count(array_unique($itemTypes))) {
+			if (array_filter($itemTypes, static fn (?string $type): bool => $type === null) !== [] || count($itemTypes) !== count(array_unique($itemTypes))) {
 				return new OpenApiType(
 					context: $context,
 					nullable: $nullable,

src/ResponseType.php

@@ -267,7 +267,7 @@ public static function resolve(string $context, TypeNode $obj): array {
 						if ($statusCode === 204 || $statusCode === 304) {
 							if ($statusCode === 304) {
 								$customHeaders = array_filter(array_keys($headers), static fn (string $header): bool => str_starts_with(strtolower($header), 'x-'));
-								if (!empty($customHeaders)) {
+								if ($customHeaders !== []) {
 									Logger::error($context, 'Custom headers are not allowed for responses with status code 304. Found: ' . implode(', ', $customHeaders));
 								}
 							}