refactor(dav): improve readability of Sabre File::put upload flow #80597
joshtrichardsstatic-code-analysis.yml
on: pull_request
changes
7s
static-code-analysis
2m 12s
static-code-analysis-security
8m 20s
static-code-analysis-ocp
1m 20s
static-code-analysis-ncu
58s
static-code-analysis-strict
42s
static-code-analysis-summary
6s
Annotations
11 errors
|
static-code-analysis
Process completed with exit code 2.
|
|
FalsableReturnStatement:
apps/dav/lib/Connector/Sabre/File.php#L245
apps/dav/lib/Connector/Sabre/File.php:245:10: FalsableReturnStatement: The declared return type 'resource' for OCA\DAV\Connector\Sabre\File::normalizePutData does not allow false, but the function returns 'false|resource' (see https://psalm.dev/137)
|
|
RedundantCondition:
apps/dav/lib/Connector/Sabre/File.php#L200
apps/dav/lib/Connector/Sabre/File.php:200:8: RedundantCondition: Operand of type OC\Files\View is always truthy (see https://psalm.dev/122)
|
|
TaintedCallable:
lib/private/ServerContainer.php#L90
lib/private/ServerContainer.php:90:17: TaintedCallable: Detected tainted text (see https://psalm.dev/243)
|
|
TaintedHtml:
lib/private/Mail/Mailer.php#L235
lib/private/Mail/Mailer.php:235:72: TaintedHtml: Detected tainted HTML (see https://psalm.dev/245)
|
|
TaintedHtml:
lib/private/Mail/Mailer.php#L215
lib/private/Mail/Mailer.php:215:83: TaintedHtml: Detected tainted HTML (see https://psalm.dev/245)
|
|
TaintedCallable:
lib/private/AppFramework/Utility/SimpleContainer.php#L131
lib/private/AppFramework/Utility/SimpleContainer.php:131:33: TaintedCallable: Detected tainted text (see https://psalm.dev/243)
|
|
TaintedCallable:
apps/workflowengine/lib/Manager.php#L687
apps/workflowengine/lib/Manager.php:687:39: TaintedCallable: Detected tainted text (see https://psalm.dev/243)
|
|
TaintedCallable:
apps/workflowengine/lib/Manager.php#L654
apps/workflowengine/lib/Manager.php:654:38: TaintedCallable: Detected tainted text (see https://psalm.dev/243)
|
|
TaintedCallable:
apps/workflowengine/lib/Manager.php#L612
apps/workflowengine/lib/Manager.php:612:38: TaintedCallable: Detected tainted text (see https://psalm.dev/243)
|
|
static-code-analysis-summary
Process completed with exit code 1.
|