fix(files): Inhibit download for non downloadable nodes in all contexts

artonge · artonge · commit 5aa63062fc11 · 2025-12-18T12:03:39.000+01:00
Signed-off-by: Louis Chmn &lt;louis@chmn.me&gt;
diff --git a/apps/files/src/components/FileEntryMixin.ts b/apps/files/src/components/FileEntryMixin.ts
@@ -367,7 +367,7 @@ export default defineComponent({
 			const metaKeyPressed = event.ctrlKey || event.metaKey || event.button === 1
 			if (metaKeyPressed || !this.defaultFileAction) {
 				// If no download permission, then we can not allow to download (direct link) the files
-				if (isPublicShare() && !isDownloadable(this.source)) {
+				if (!isDownloadable(this.source)) {
 					return
 				}
 

Original file line number	Diff line number	Diff line change
`@@ -367,7 +367,7 @@ export default defineComponent({`
`367`	`367`	`const metaKeyPressed = event.ctrlKey \|\| event.metaKey \|\| event.button === 1`
`368`	`368`	`if (metaKeyPressed \|\| !this.defaultFileAction) {`
`369`	`369`	`// If no download permission, then we can not allow to download (direct link) the files`
`370`		`- if (isPublicShare() && !isDownloadable(this.source)) {`
	`370`	`+ if (!isDownloadable(this.source)) {`
`371`	`371`	`return`
`372`	`372`	`}`
`373`	`373`