Skip to content

Commit 673815b

Browse files
authored
Merge pull request #56574 from nextcloud/artonge/fix/readd_attributes_checkboxes
fix(user_ldap): Re-introduce easy login attributes checkboxes
2 parents ccc0e9f + 6a1712d commit 673815b

File tree

6 files changed

+19
-5
lines changed

6 files changed

+19
-5
lines changed

apps/user_ldap/src/components/SettingsTabs/LoginTab.vue

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,20 @@
88
{{ t('user_ldap', 'When logging in, {instanceName} will find the user based on the following attributes:', { instanceName }) }}
99
</legend>
1010

11+
<NcCheckboxRadioSwitch
12+
:model-value="ldapConfigProxy.ldapLoginFilterUsername === '1'"
13+
:description="t('user_ldap', 'Allows login against the LDAP/AD username, which is either \'uid\' or \'sAMAccountName\' and will be detected.')"
14+
@update:model-value="ldapConfigProxy.ldapLoginFilterUsername = $event ? '1' : '0'">
15+
{{ t('user_ldap', 'LDAP/AD Username:') }}
16+
</NcCheckboxRadioSwitch>
17+
18+
<NcCheckboxRadioSwitch
19+
:model-value="ldapConfigProxy.ldapLoginFilterEmail === '1'"
20+
:description="t('user_ldap', 'Allows login against an email attribute. \'mail\' and \'mailPrimaryAddress\' allowed.')"
21+
@update:model-value="ldapConfigProxy.ldapLoginFilterEmail = $event ? '1' : '0'">
22+
{{ t('user_ldap', 'LDAP/AD Email Address:') }}
23+
</NcCheckboxRadioSwitch>
24+
1125
<div class="ldap-wizard__login__line ldap-wizard__login__login-attributes">
1226
<NcSelect
1327
v-model="ldapLoginFilterAttributes"

apps/user_ldap/src/components/SettingsTabs/UsersTab.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ async function reloadFilters() {
120120
121121
const response2 = await callWizard('getUserLoginFilter', props.configId)
122122
// Not using ldapConfig to avoid triggering the save logic.
123-
ldapConfigs.value[props.configId]!.ldapLoginFilter = (response2.changes?.ldap_userlogin_filter as string | undefined) ?? ''
123+
ldapConfigs.value[props.configId]!.ldapLoginFilter = (response2.changes?.ldap_login_filter as string | undefined) ?? ''
124124
}
125125
}
126126

dist/user_ldap-settings-admin.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
/* extracted by css-entry-points-plugin */
2-
@import './user_ldap-user_ldap-settings-admin-BSius8Dv.chunk.css';
2+
@import './user_ldap-user_ldap-settings-admin-1lfli3rS.chunk.css';
33
@import './NcSettingsSection-BfK7eHNT-BFoYkIs3.chunk.css';
44
@import './Plus-BhZ0LWiU.chunk.css';

dist/user_ldap-settings-admin.mjs

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

dist/user_ldap-settings-admin.mjs.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/user_ldap-user_ldap-settings-admin-BSius8Dv.chunk.css renamed to dist/user_ldap-user_ldap-settings-admin-1lfli3rS.chunk.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)